Message-ID: <4CE6B87C.2010203@oracle.com>
Date: Fri, 19 Nov 2010 09:48:44 -0800
From: Randy Dunlap <randy.dunlap@oracle.com>
Organization: Oracle Linux Engineering
User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.5) Gecko/20091209 Fedora/3.0-3.fc11 Thunderbird/3.0
MIME-Version: 1.0
To: Greg KH <gregkh@suse.de>
CC: Stephen Rothwell <sfr@canb.auug.org.au>, Pavel Machek <pavel@ucw.cz>,
        linux-next@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -next] staging: fix winbond build, needs delay.h
References: <20101119143207.b2d5731e.sfr@canb.auug.org.au> <20101119093018.340dab03.randy.dunlap@oracle.com> <20101119173831.GA6098@suse.de>
In-Reply-To: <20101119173831.GA6098@suse.de>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1140
Lines: 25

On 11/19/10 09:38, Greg KH wrote:
> On Fri, Nov 19, 2010 at 09:30:18AM -0800, Randy Dunlap wrote:
>> From: Randy Dunlap <randy.dunlap@oracle.com>
>>
>> winbond drivers use msleep() and delay(), so include linux/delay.h
>> in a common header file to prevent build errors.
>>
>> drivers/staging/winbond/phy_calibration.c:987: error: implicit declaration of function 'msleep'
>> drivers/staging/winbond/phy_calibration.c:1556: error: implicit declaration of function 'udelay'
>> drivers/staging/winbond/reg.c:894: error: implicit declaration of function 'msleep'
>> drivers/staging/winbond/reg.c:1178: error: implicit declaration of function 'udelay'
> 
> Is this error showing up in Linus's tree, or only in linux-next?

I saw it in linux-next, but it looks like it should also be a build error
in mainline.

-- 
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/