Date: Fri, 19 Nov 2010 09:54:43 -0800
From: Greg KH <gregkh@suse.de>
To: Randy Dunlap <randy.dunlap@oracle.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>, Pavel Machek <pavel@ucw.cz>,
        linux-next@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -next] staging: fix winbond build, needs delay.h
Message-ID: <20101119175443.GA6326@suse.de>
References: <20101119143207.b2d5731e.sfr@canb.auug.org.au>
 <20101119093018.340dab03.randy.dunlap@oracle.com>
 <20101119173831.GA6098@suse.de>
 <4CE6B87C.2010203@oracle.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4CE6B87C.2010203@oracle.com>
User-Agent: Mutt/1.5.20 (2009-06-14)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1208
Lines: 26

On Fri, Nov 19, 2010 at 09:48:44AM -0800, Randy Dunlap wrote:
> On 11/19/10 09:38, Greg KH wrote:
> > On Fri, Nov 19, 2010 at 09:30:18AM -0800, Randy Dunlap wrote:
> >> From: Randy Dunlap <randy.dunlap@oracle.com>
> >>
> >> winbond drivers use msleep() and delay(), so include linux/delay.h
> >> in a common header file to prevent build errors.
> >>
> >> drivers/staging/winbond/phy_calibration.c:987: error: implicit declaration of function 'msleep'
> >> drivers/staging/winbond/phy_calibration.c:1556: error: implicit declaration of function 'udelay'
> >> drivers/staging/winbond/reg.c:894: error: implicit declaration of function 'msleep'
> >> drivers/staging/winbond/reg.c:1178: error: implicit declaration of function 'udelay'
> > 
> > Is this error showing up in Linus's tree, or only in linux-next?
> 
> I saw it in linux-next, but it looks like it should also be a build error
> in mainline.

Ok, thanks, I'll queue it up for Linus's tree then.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/