Message-ID: <4CE6C9A4.4090307@metafoo.de>
Date: Fri, 19 Nov 2010 20:01:56 +0100
From: Lars-Peter Clausen <lars@metafoo.de>
User-Agent: Mozilla-Thunderbird 2.0.0.24 (X11/20100329)
MIME-Version: 1.0
To: Vasiliy Kulikov <segoon@openwall.com>
CC: kernel-janitors@vger.kernel.org, Anton Vorontsov <cbouatmailru@gmail.com>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] power: gpio-charger: fix potential NULL dereference
References: <1290192114-11659-1-git-send-email-segoon@openwall.com>
In-Reply-To: <1290192114-11659-1-git-send-email-segoon@openwall.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1151
Lines: 38

Vasiliy Kulikov wrote:
> kzalloc() result is not compared with NULL.  It might lead to NULL
> pointer dereference in OOM situation.
> 
> Signed-off-by: Vasiliy Kulikov <segoon@openwall.com>
> ---
>  Compile tested only.
> 
>  drivers/power/gpio-charger.c |    4 ++++
>  1 files changed, 4 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/power/gpio-charger.c b/drivers/power/gpio-charger.c
> index fccbe99..b07a71c 100644
> --- a/drivers/power/gpio-charger.c
> +++ b/drivers/power/gpio-charger.c
> @@ -87,6 +87,10 @@ static int __devinit gpio_charger_probe(struct platform_device *pdev)
>  	}
>  
>  	gpio_charger = kzalloc(sizeof(*gpio_charger), GFP_KERNEL);
> +	if (!gpio_charger) {
> +		dev_err(&pdev->dev, "kzalloc failed\n");
> +		return -ENOMEM;
> +	}
>  
>  	charger = &gpio_charger->charger;
>  

Hi

I already send a similar patch yesterday.
See http://lkml.org/lkml/2010/11/18/632

- Lars
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/