Date: Fri, 19 Nov 2010 12:57:09 -0800
From: Greg KH <gregkh@suse.de>
To: Vasiliy Kulikov <segoon@openwall.com>
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers: base: core: do not put noninitialized devices
Message-ID: <20101119205709.GA17531@suse.de>
References: <1290192100-11451-1-git-send-email-segoon@openwall.com>
 <20101119190242.GA14328@suse.de>
 <20101119191424.GA12273@albatros>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20101119191424.GA12273@albatros>
User-Agent: Mutt/1.5.20 (2009-06-14)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1534
Lines: 47

On Fri, Nov 19, 2010 at 10:14:25PM +0300, Vasiliy Kulikov wrote:
> Hi Greg,
> 
> On Fri, Nov 19, 2010 at 11:02 -0800, Greg KH wrote:
> > On Fri, Nov 19, 2010 at 09:41:40PM +0300, Vasiliy Kulikov wrote:
> > > If kobject_set_name_vargs() fails then put_device() frees
> > > device with zero kobj->state_initialized.  This leads to WARN().
> > 
> > Have you seen this happen?
> 
> No, I've just analized the code.  Without device_initialize() ->kobj is
> not initialized:
> 
> 	kobject_init(&dev->kobj, &device_ktype) calls
> 
> 	kobject_init_internal(kobj) calls
> 
> 	kobj->state_initialized = 1;
> 
> kobject_put() calls WARN if state_initialized == 0:
> 
>     void kobject_put(struct kobject *kobj)
>     {
>         if (kobj) {
>             if (!kobj->state_initialized)
>                 WARN(1, KERN_WARNING "kobject: '%s' (%p): is not "
>                        "initialized, yet kobject_put() is being "
>                        "called.\n", kobject_name(kobj), kobj);
> 
> 
> I got the stack dump with similar code:
> 
>     struct device *dev = kzalloc(sizeof(*dev), GFP_KERNEL);
>     put_device(dev);

Sure, that's illegal code, and we want to warn about that.  So I would
say, if an error happens, we want to see this message so the code should
stay as-is.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/