Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757942Ab0KTE0L (ORCPT ); Fri, 19 Nov 2010 23:26:11 -0500 Received: from e39.co.us.ibm.com ([32.97.110.160]:42899 "EHLO e39.co.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755152Ab0KTE0J (ORCPT ); Fri, 19 Nov 2010 23:26:09 -0500 Date: Sat, 20 Nov 2010 09:55:57 +0530 From: Balbir Singh To: Lennart Poettering Cc: Ben Gamari , Linus Torvalds , David Miller , tytso@mit.edu, a.p.zijlstra@chello.nl, debiandev@gmail.com, alan@lxorguk.ukuu.org.uk, dhaval.giani@gmail.com, efault@gmx.de, vgoyal@redhat.com, oleg@redhat.com, markus@trippelsdorf.de, mathieu.desnoyers@efficios.com, mingo@elte.hu, linux-kernel@vger.kernel.org Subject: Re: [RFC/RFT PATCH v3] sched: automated per tty task groups Message-ID: <20101120042557.GA12043@balbir.in.ibm.com> Reply-To: balbir@linux.vnet.ibm.com References: <20101119.082944.226775934.davem@davemloft.net> <20101119163430.GA12353@tango.0pointer.de> <20101119.084302.71115175.davem@davemloft.net> <87mxp53z72.fsf@gmail.com> <20101120011330.GB4183@tango.0pointer.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <20101120011330.GB4183@tango.0pointer.de> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2112 Lines: 46 * Lennart Poettering [2010-11-20 02:13:30]: > On Fri, 19.11.10 14:12, Ben Gamari (bgamari.foss@gmail.com) wrote: > > > > > On Fri, 19 Nov 2010 09:51:14 -0800, Linus Torvalds wrote: > > > And the user level approach? I think it's fine too. If you run systemd > > > for other reasons (or if the gnome people add it to the task launcher > > > or whatever), doing it there isn't wrong. I personally think it's > > > somewhat disgusting to have a user-level callback with processes etc > > > just to clean up a group, but whatever. As long as it's not common, > > > who cares? > > > > > On that note, is there a good reason why the notify_on_release interface > > works the way it does? Wouldn't it be simpler if the cgroup simply > > provided a file on which a process (e.g. systemd) could block? > > The notify_on_release interface is awful indeed. Feels like the old > hotplug interface where each module request by the kernel caused a > hotplug script to be spawned by the kernel. > > However, I am not sure I like the idea of having pollable files like that, > because in the systemd case I am very much interested in getting > recursive notifications, i.e. I want to register once for getting > notifications for a full subtree instead of having to register for each > cgroup individually. > > My personal favourite solution would be to get a netlink msg when a > cgroup runs empty. That way multiple programs could listen to the events > at the same time, and we'd have an easy way to subscribe to a whole > hierarchy of groups. > The netlink message should not be hard to do if we agree to work on it. The largest objections I've heard is that netlink implies network programming and most users want to be able to script in their automation and network scripting is hard. -- Three Cheers, Balbir -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/