Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752217Ab0KTKsK (ORCPT ); Sat, 20 Nov 2010 05:48:10 -0500 Received: from casper.infradead.org ([85.118.1.10]:59074 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751760Ab0KTKsI convert rfc822-to-8bit (ORCPT ); Sat, 20 Nov 2010 05:48:08 -0500 Subject: Re: [PATCH 3/5] scheduler: cpuacct: Enable platform hooks to track cpuusage for CPU frequencies From: Peter Zijlstra To: John Stultz Cc: lkml , Mike Chan , Ingo Molnar In-Reply-To: <1290218934-8544-4-git-send-email-john.stultz@linaro.org> References: <1290218934-8544-1-git-send-email-john.stultz@linaro.org> <1290218934-8544-4-git-send-email-john.stultz@linaro.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT Date: Sat, 20 Nov 2010 11:48:24 +0100 Message-ID: <1290250104.2118.4.camel@laptop> Mime-Version: 1.0 X-Mailer: Evolution 2.30.3 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1278 Lines: 31 On Fri, 2010-11-19 at 18:08 -0800, John Stultz wrote: > From: Mike Chan > > Introduce new platform callback hooks for cpuacct for tracking CPU frequencies > > Not all platforms / architectures have a set CPU_FREQ_TABLE defined > for CPU transition speeds. In order to track time spent in at various > CPU frequencies, we enable platform callbacks from cpuacct for this accounting. > > Architectures that support overclock boosting, or don't have pre-defined > frequency tables can implement their own bucketing system that makes sense > given their cpufreq scaling abilities. > > New file: > cpuacct.cpufreq reports the CPU time (in nanoseconds) spent at each CPU > frequency. I utterly detest all such accounting crap.. it adds ABI constraints it add runtime overhead. etc.. Can't you get the same information by using the various perf bits? If you trace the cpufreq changes you can compute the time spend in each power state, if you additionally trace the sched_switch you can compute it for each task. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/