DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
  s=s1024; d=pacbell.net;
  h=Message-ID:X-YMail-OSG:Received:X-Mailer:Date:From:Subject:To:Cc:In-Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding;
  b=14F/0ySZ0R6Al3OR+Ik9uGSqLObq0dFe70IBP3Bd/nnDNfP9OHOyYoqbq/149Vb4E+sBrVtbdngG9avCuRD0OBJCM9OzSv3ftyhTpL+qmNOAGvuBhHJ0oEw4Xh3gxM0iu79ckZtLdOVixldtr6If7B2A8E92iD2XFCreNRrrlZg=;
Message-ID: <616676.83025.qm@web180301.mail.gq1.yahoo.com>
Date: Sat, 20 Nov 2010 14:59:28 -0800 (PST)
From: David Brownell <david-b@pacbell.net>
Subject: Re: [PATCH 6/6] atmel_spi: fix warning In function 'atmel_spi_dma_map_xfer'
To: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>,
        =?iso-8859-1?Q?Uwe_Kleine-K=F6nig?= 
	<u.kleine-koenig@pengutronix.de>
Cc: Nicolas Ferre <nicolas.ferre@atmel.com>,
        Patrice Vilchez <patrice.vilchez@atmel.com>,
        linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        spi-devel-general@lists.sourceforge.net
In-Reply-To: <20101120214820.GG8942@pengutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 552
Lines: 19


--- On Sat, 11/20/10, Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de> wrote:

> > +??? ??? void
> *nonconst_tx = (void *)xfer->tx_buf; /* shut up gcc */

Reads like a bad patch to me. Fix the bug,
don't just silence GCC.  Or at least use
a better comment mentioning a constness
cast problems).

- Dave

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/