Date: Sun, 21 Nov 2010 03:19:34 +0100
From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: David Brownell <david-b@pacbell.net>
Cc: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= 
	<u.kleine-koenig@pengutronix.de>,
        Nicolas Ferre <nicolas.ferre@atmel.com>,
        Patrice Vilchez <patrice.vilchez@atmel.com>,
        linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        spi-devel-general@lists.sourceforge.net
Subject: Re: [PATCH 6/6] atmel_spi: fix warning In function
 'atmel_spi_dma_map_xfer'
Message-ID: <20101121021934.GH4216@game.jcrosoft.org>
References: <20101120214820.GG8942@pengutronix.de>
 <616676.83025.qm@web180301.mail.gq1.yahoo.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <616676.83025.qm@web180301.mail.gq1.yahoo.com>
User-Agent: Mutt/1.5.20 (2009-06-14)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 656
Lines: 22

On 14:59 Sat 20 Nov     , David Brownell wrote:
> 
> 
> --- On Sat, 11/20/10, Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de> wrote:
> 
> > > +??? ??? void
> > *nonconst_tx = (void *)xfer->tx_buf; /* shut up gcc */
> 
> Reads like a bad patch to me. Fix the bug,
> don't just silence GCC.  Or at least use
> a better comment mentioning a constness
> cast problems).

ok I change the comment

Best Regards,
J.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/