Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752065Ab0KVGoG (ORCPT ); Mon, 22 Nov 2010 01:44:06 -0500 Received: from cantor.suse.de ([195.135.220.2]:58008 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751342Ab0KVGoF (ORCPT ); Mon, 22 Nov 2010 01:44:05 -0500 Date: Mon, 22 Nov 2010 07:44:04 +0100 Message-ID: From: Takashi Iwai To: Joe Perches Cc: Jiri Kosina , Jaroslav Kysela , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 14/14] sound/ppc: Use printf extension %pR for struct resource In-Reply-To: <434a77317cc09300e79b7768170eec7ae04adb92.1289597644.git.joe@perches.com> References: <434a77317cc09300e79b7768170eec7ae04adb92.1289597644.git.joe@perches.com> User-Agent: Wanderlust/2.15.6 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.7 Emacs/23.1 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1799 Lines: 55 At Fri, 12 Nov 2010 13:38:04 -0800, Joe Perches wrote: > > Using %pR standardizes the struct resource output. > > Signed-off-by: Joe Perches Applied now. Thanks. Takashi > --- > sound/ppc/pmac.c | 12 ++++-------- > 1 files changed, 4 insertions(+), 8 deletions(-) > > diff --git a/sound/ppc/pmac.c b/sound/ppc/pmac.c > index 8508117..b47cfd4 100644 > --- a/sound/ppc/pmac.c > +++ b/sound/ppc/pmac.c > @@ -1228,10 +1228,8 @@ int __devinit snd_pmac_new(struct snd_card *card, struct snd_pmac **chip_return) > chip->rsrc[i].start + 1, > rnames[i]) == NULL) { > printk(KERN_ERR "snd: can't request rsrc " > - " %d (%s: 0x%016llx:%016llx)\n", > - i, rnames[i], > - (unsigned long long)chip->rsrc[i].start, > - (unsigned long long)chip->rsrc[i].end); > + " %d (%s: %pR)\n", > + i, rnames[i], &chip->rsrc[i]); > err = -ENODEV; > goto __error; > } > @@ -1256,10 +1254,8 @@ int __devinit snd_pmac_new(struct snd_card *card, struct snd_pmac **chip_return) > chip->rsrc[i].start + 1, > rnames[i]) == NULL) { > printk(KERN_ERR "snd: can't request rsrc " > - " %d (%s: 0x%016llx:%016llx)\n", > - i, rnames[i], > - (unsigned long long)chip->rsrc[i].start, > - (unsigned long long)chip->rsrc[i].end); > + " %d (%s: %pR)\n", > + i, rnames[i], &chip->rsrc[i]); > err = -ENODEV; > goto __error; > } > -- > 1.7.3.1.g432b3.dirty > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/