Date: Mon, 22 Nov 2010 07:56:41 +0100
Message-ID: <s5htyj9rgly.wl%tiwai@suse.de>
From: Takashi Iwai <tiwai@suse.de>
To: Vasiliy Kulikov <segoon@openwall.com>
Cc: kernel-janitors@vger.kernel.org, Jaroslav Kysela <perex@perex.cz>,
        alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: snd-atmel-abdac: test wrong variable
In-Reply-To: <1290361209-15121-1-git-send-email-segoon@openwall.com>
References: <1290361209-15121-1-git-send-email-segoon@openwall.com>
User-Agent: Wanderlust/2.15.6 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.7 Emacs/23.1
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1090
Lines: 40

At Sun, 21 Nov 2010 20:40:07 +0300,
Vasiliy Kulikov wrote:
> 
> After clk_get() pclk is checked second time instead of sample_clk check.
> 
> Signed-off-by: Vasiliy Kulikov <segoon@openwall.com>

Applied now.  Thanks.


Takashi


> ---
>  Compile tested only.
> 
>  sound/atmel/abdac.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/sound/atmel/abdac.c b/sound/atmel/abdac.c
> index f2f41c8..4e47baa 100644
> --- a/sound/atmel/abdac.c
> +++ b/sound/atmel/abdac.c
> @@ -420,7 +420,7 @@ static int __devinit atmel_abdac_probe(struct platform_device *pdev)
>  		return PTR_ERR(pclk);
>  	}
>  	sample_clk = clk_get(&pdev->dev, "sample_clk");
> -	if (IS_ERR(pclk)) {
> +	if (IS_ERR(sample_clk)) {
>  		dev_dbg(&pdev->dev, "no sample clock\n");
>  		retval = PTR_ERR(pclk);
>  		goto out_put_pclk;
> -- 
> 1.7.0.4
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/