Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752364Ab0KVHn7 (ORCPT ); Mon, 22 Nov 2010 02:43:59 -0500 Received: from mail-ey0-f174.google.com ([209.85.215.174]:36129 "EHLO mail-ey0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751653Ab0KVHn6 (ORCPT ); Mon, 22 Nov 2010 02:43:58 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:in-reply-to:references:x-mailer :mime-version:content-type:content-transfer-encoding; b=g+uniK5CZssITRgBKtYbsGz30u0NAk1/GFsAkdF1tO8KOymCPy9BMd4NBpGdWGocgC mOlJ6MwJbkdOtcjO7nwIQgYOfOZlirAAZgqttjqaOpEmonn3lFiTQQxUXw6SBw+ZlVgI /AA6M2VlhpU9ynE2U1WLdi+gcSiCfiDYgtdCg= Date: Mon, 22 Nov 2010 09:43:53 +0200 From: Jarkko Nikula To: Vasiliy Kulikov Cc: kernel-janitors@vger.kernel.org, Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Timur Tabi , Lars-Peter Clausen , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ASoC: atmel: test wrong variable Message-Id: <20101122094353.f76830b5.jhnikula@gmail.com> In-Reply-To: <1290361216-15166-1-git-send-email-segoon@openwall.com> References: <1290361216-15166-1-git-send-email-segoon@openwall.com> X-Mailer: Sylpheed 3.0.2 (GTK+ 2.20.1; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1174 Lines: 35 On Sun, 21 Nov 2010 20:40:14 +0300 Vasiliy Kulikov wrote: > After clk_get() mclk is checked second time instead of pllb check. > > Signed-off-by: Vasiliy Kulikov > --- > Cannot compile this driver, so it is not tested. > > sound/soc/atmel/sam9g20_wm8731.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/sound/soc/atmel/sam9g20_wm8731.c b/sound/soc/atmel/sam9g20_wm8731.c > index da9c303..68072a2 100644 > --- a/sound/soc/atmel/sam9g20_wm8731.c > +++ b/sound/soc/atmel/sam9g20_wm8731.c > @@ -223,7 +223,7 @@ static int __init at91sam9g20ek_init(void) > } > > pllb = clk_get(NULL, "pllb"); > - if (IS_ERR(mclk)) { > + if (IS_ERR(pllb)) { > printk(KERN_ERR "ASoC: Failed to get PLLB\n"); > ret = PTR_ERR(mclk); Update also PTR_ERR as otherwise we don't return any error code (mclk is ok at this point but pllb has an error). -- Jarkko -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/