Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752757Ab0KVPiI (ORCPT ); Mon, 22 Nov 2010 10:38:08 -0500 Received: from mga02.intel.com ([134.134.136.20]:22502 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752254Ab0KVPiB (ORCPT ); Mon, 22 Nov 2010 10:38:01 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.59,236,1288594800"; d="scan'208";a="576324181" Subject: Re: [PATCH 56/62] iwlwifi: Use static const From: "Guy, Wey-Yi" To: Joe Perches Cc: Stefano Brivio , "Chatre, Reinette" , Intel Linux Wireless , "John W. Linville" , "linux-wireless@vger.kernel.org" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" In-Reply-To: <2773a20a26f4e326f0849e8ae8fb4f347d6a6ecb.1290305776.git.joe@perches.com> References: <2773a20a26f4e326f0849e8ae8fb4f347d6a6ecb.1290305776.git.joe@perches.com> Content-Type: text/plain Date: Mon, 22 Nov 2010 07:37:03 -0800 Message-Id: <1290440223.7946.0.camel@wwguy-ubuntu> Mime-Version: 1.0 X-Mailer: Evolution 2.26.1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1201 Lines: 30 Hi Joe, On Sat, 2010-11-20 at 18:38 -0800, Joe Perches wrote: > Using static const generally increases object text and decreases data size. > It also generally decreases overall object size. > > text data bss dec hex filename > 48644 57 12120 60821 ed95 drivers/net/wireless/b43/phy_n.o.new > 48661 57 12120 60838 eda6 drivers/net/wireless/b43/phy_n.o.old > 37906 86 7904 45896 b348 drivers/net/wireless/iwlwifi/iwl-agn-lib.o.new > 37937 86 7904 45927 b367 drivers/net/wireless/iwlwifi/iwl-agn-lib.o.old > 37781 523 6752 45056 b000 drivers/net/wireless/iwlwifi/iwl-3945.o.new > 37781 523 6752 45056 b000 drivers/net/wireless/iwlwifi/iwl-3945.o.old > > Changed b43_nphy_write_clip_detection to take a const u16 * > > Signed-off-by: Joe Perches > --- I don't see size difference on 3945, otherwise the patch looks ok to me Wey -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/