Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752299Ab0KVQ3T (ORCPT ); Mon, 22 Nov 2010 11:29:19 -0500 Received: from 74-93-104-97-Washington.hfc.comcastbusiness.net ([74.93.104.97]:41994 "EHLO sunset.davemloft.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750790Ab0KVQ3S (ORCPT ); Mon, 22 Nov 2010 11:29:18 -0500 Date: Mon, 22 Nov 2010 08:29:43 -0800 (PST) Message-Id: <20101122.082943.104076370.davem@davemloft.net> To: sonnyrao@linux.vnet.ibm.com Cc: netdev@vger.kernel.org, miltonm@bga.com, ron.mercer@qlogic.com, linux-driver@qlogic.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] qlge: Fix incorrect usage of module parameters and netdev msg level From: David Miller In-Reply-To: <1290075903-3038-1-git-send-email-sonnyrao@linux.vnet.ibm.com> References: <1290075903-3038-1-git-send-email-sonnyrao@linux.vnet.ibm.com> X-Mailer: Mew version 6.3 on Emacs 23.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 699 Lines: 18 From: Sonny Rao Date: Thu, 18 Nov 2010 04:25:03 -0600 > Driver appears to be mistaking the permission field with default value > in the case of debug and qlge_irq_type. > > Driver is also passing debug as a bitmask into netif_msg_init() > which really wants a number of bits, so fix that. > > Signed-off-by: Milton Miller > Signed-off-by: Sonny Rao Applied, thanks Sonny. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/