Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755201Ab0KVRIe (ORCPT ); Mon, 22 Nov 2010 12:08:34 -0500 Received: from smtp1.linux-foundation.org ([140.211.169.13]:44433 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751810Ab0KVRId (ORCPT ); Mon, 22 Nov 2010 12:08:33 -0500 MIME-Version: 1.0 In-Reply-To: <949636.86471.qm@web31809.mail.mud.yahoo.com> References: <949636.86471.qm@web31809.mail.mud.yahoo.com> From: Linus Torvalds Date: Mon, 22 Nov 2010 09:07:51 -0800 Message-ID: Subject: Re: [PATCH repost 3] [SCSI] Retrieve the Caching mode page To: ltuikov@yahoo.com Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, linux-usb@vger.kernel.org, Greg KH , James Bottomley Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 947 Lines: 23 On Mon, Nov 22, 2010 at 8:56 AM, Luben Tuikov wrote: > > Some kernel transport drivers unconditionally disable > retrieval of the Caching mode page. One such for example is > the BBB/CBI transport over USB. One reason for that is that historically we've seen devices that simply go crazy - to the point of simply stopping to respond to anything - when you ask for pages that Windows doesn't ask for. It's especially common on USB storage, but it happens elsewhere too. The device firmware simply hasn't ever been tested in that situation, and it's buggy. So I don't mind the patch per se, but I think it's potentially way more dangerous than it looks. Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/