Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756993Ab0KVS2H (ORCPT ); Mon, 22 Nov 2010 13:28:07 -0500 Received: from cantor.suse.de ([195.135.220.2]:53792 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756567Ab0KVS2C (ORCPT ); Mon, 22 Nov 2010 13:28:02 -0500 Date: Mon, 22 Nov 2010 19:27:59 +0100 From: Jan Kara To: Lukas Czerner Cc: "Darrick J. Wong" , "Theodore Ts'o" , Eric Sandeen , "Patrick J. LoPresti" , linux-kernel , linux-ext4 , Mingming Cao , Jan Kara Subject: Re: [PATCH] ext3: Return error code from generic_check_addressable Message-ID: <20101122182759.GA6141@quack.suse.cz> References: <20101115214831.GA18195@tux1.beaverton.ibm.com> <4CE1AC38.9040201@redhat.com> <20101115230346.GB18195@tux1.beaverton.ibm.com> <20101116225744.GD18195@tux1.beaverton.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1586 Lines: 50 On Thu 18-11-10 09:52:51, Lukas Czerner wrote: > On Tue, 16 Nov 2010, Darrick J. Wong wrote: > > > ext3: Return error code from generic_check_accessible > > > > ext3_fill_super should return the error code that generic_check_accessible > > returns when an error condition occurs. > > > > Signed-off-by: Darrick J. Wong > > --- > > > > fs/ext3/super.c | 6 ++++-- > > 1 files changed, 4 insertions(+), 2 deletions(-) > > > > diff --git a/fs/ext3/super.c b/fs/ext3/super.c > > index 2fedaf8..960629b 100644 > > --- a/fs/ext3/super.c > > +++ b/fs/ext3/super.c > > @@ -1842,13 +1842,15 @@ static int ext3_fill_super (struct super_block *sb, void *data, int silent) > > goto failed_mount; > > } > > > > - if (generic_check_addressable(sb->s_blocksize_bits, > > - le32_to_cpu(es->s_blocks_count))) { > > + err = generic_check_addressable(sb->s_blocksize_bits, > > + le32_to_cpu(es->s_blocks_count)); > > + if (err) { > > ext3_msg(sb, KERN_ERR, > > "error: filesystem is too large to mount safely"); > > if (sizeof(sector_t) < 8) > > ext3_msg(sb, KERN_ERR, > > "error: CONFIG_LBDAF not enabled"); > > + ret = err; > > goto failed_mount; > > } > > > > > > Add Jan Kara to cc list. Thanks for forwarding. Merged. Honza -- Jan Kara SUSE Labs, CR -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/