Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752545Ab0KWJ7e (ORCPT ); Tue, 23 Nov 2010 04:59:34 -0500 Received: from mx3.mail.elte.hu ([157.181.1.138]:54262 "EHLO mx3.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751024Ab0KWJ7d (ORCPT ); Tue, 23 Nov 2010 04:59:33 -0500 Date: Tue, 23 Nov 2010 10:59:17 +0100 From: Ingo Molnar To: "Berg, Johannes" Cc: Andrew Morton , Arnd Hannemann , Michal Hocko , LKML , Richard Purdie Subject: Re: 5ada28bf76752 causes compilation error if !CONFIG_LEDS_CLASS Message-ID: <20101123095917.GA28998@elte.hu> References: <4CEAA151.7050404@arndnet.de> <20101123063200.GA23907@elte.hu> <20101122233654.117eef93.akpm@linux-foundation.org> <20101123075742.GA28714@elte.hu> <20101123000232.e51b99b7.akpm@linux-foundation.org> <20101123091756.GA22530@elte.hu> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.20 (2009-08-17) X-ELTE-SpamScore: -2.0 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-2.0 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.2.5 -2.0 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 719 Lines: 24 * Berg, Johannes wrote: > > It fails to build on x86 64-bit allmodconfig: > > > > drivers/leds/led-triggers.c:39:20: error: ‘TRIG_NAME_MAX’ undeclared > > (first use in this function) > > Grr. I give up on the modular thing ... > > There are a whole bunch of ifdefs on TRIGGERS, which need to be > || modular, but the easier thing is to remove the bool->tristate > changes from my patch. Please post a patch that does so. Thanks, Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/