Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752391Ab0KWKda (ORCPT ); Tue, 23 Nov 2010 05:33:30 -0500 Received: from mail-ww0-f44.google.com ([74.125.82.44]:53921 "EHLO mail-ww0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751991Ab0KWKd3 (ORCPT ); Tue, 23 Nov 2010 05:33:29 -0500 Subject: Re: [PATCH 1/3] ASoC: max98088 - fix a memory leak From: Liam Girdwood To: Axel Lin Cc: linux-kernel , Mark Brown , Peter Hsiang , Jesse Marroquin In-Reply-To: <1290498981.7286.4.camel@mola> References: <1290498981.7286.4.camel@mola> Content-Type: text/plain; charset="UTF-8" Date: Tue, 23 Nov 2010 10:33:24 +0000 Message-ID: <1290508404.3449.7.camel@odin> Mime-Version: 1.0 X-Mailer: Evolution 2.30.3 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1093 Lines: 35 On Tue, 2010-11-23 at 15:56 +0800, Axel Lin wrote: > Signed-off-by: Axel Lin > --- > sound/soc/codecs/max98088.c | 3 +++ > 1 files changed, 3 insertions(+), 0 deletions(-) > > diff --git a/sound/soc/codecs/max98088.c b/sound/soc/codecs/max98088.c > index 4ee5b1a..b679586 100644 > --- a/sound/soc/codecs/max98088.c > +++ b/sound/soc/codecs/max98088.c > @@ -2020,7 +2020,10 @@ err_access: > > static int max98088_remove(struct snd_soc_codec *codec) > { > + struct max98088_priv *max98088 = snd_soc_codec_get_drvdata(codec); > + > max98088_set_bias_level(codec, SND_SOC_BIAS_OFF); > + kfree(max98088->eq_texts); > > return 0; > } All Acked-by: Liam Girdwood -- Freelance Developer, SlimLogic Ltd ASoC and Voltage Regulator Maintainer. http://www.slimlogic.co.uk -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/