Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753556Ab0KWN3V (ORCPT ); Tue, 23 Nov 2010 08:29:21 -0500 Received: from na3sys009aog107.obsmtp.com ([74.125.149.197]:53651 "HELO na3sys009aog107.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1751568Ab0KWN3U convert rfc822-to-8bit (ORCPT ); Tue, 23 Nov 2010 08:29:20 -0500 MIME-Version: 1.0 In-Reply-To: References: <95f48a32a0256ecdb7148aa08d16f64928a7e5d8.1289935504.git.bengardiner@nanometrics.ca> Date: Tue, 23 Nov 2010 08:29:17 -0500 Message-ID: Subject: Re: [PATCH v2 2/4] da850-evm: add UI Expander pushbuttons From: Ben Gardiner To: "Nori, Sekhar" Cc: Kevin Hilman , "davinci-linux-open-source@linux.davincidsp.com" , "linux-input@vger.kernel.org" , Dmitry Torokhov , "Govindarajan, Sriramakrishnan" , Paul Mundt , "linux-kernel@vger.kernel.org" , Alexander Clouter , Chris Cordahi Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1147 Lines: 38 Hi Sekhar, On Tue, Nov 23, 2010 at 7:38 AM, Nori, Sekhar wrote: > On Mon, Nov 22, 2010 at 19:20:48, Ben Gardiner wrote: >> [...] >> config KEYBOARD_GPIO >> ? ? ? ? default MACH_DAVINCI_DA850_EVM >> ? ? ? ? select INPUT_POLLDEV >> >> So 1) gpio-keys functionality is default for the da850evm and 2) >> whenever gpio-keys is enabled so is INPUT_POLLDEV. > > This looks better than what was posted earlier, but I am not > sure if platforms should influence driver configuration this > way. > > I guess I am just afraid that this makes a precedent for > many driver config symbols to get replicated in the platform > Kconfig files. Ok . I understand your concerns. > Lets see if others have an opinion on this. Yes, good idea. I would welcome more opinions on this and any other aspects of the patch series. Best Regards, Ben Gardiner --- Nanometrics Inc. http://www.nanometrics.ca -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/