Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753891Ab0KWNx0 (ORCPT ); Tue, 23 Nov 2010 08:53:26 -0500 Received: from mail-gw0-f46.google.com ([74.125.83.46]:41226 "EHLO mail-gw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752109Ab0KWNxZ (ORCPT ); Tue, 23 Nov 2010 08:53:25 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:x-enigmail-version:content-type :content-transfer-encoding; b=xI4IY/rsgQZg0hn9dutmr/RBLob4v4JgL0vM54HX53T0AsUiEs7S2DFgXiD3GX8xRI kNFq/CxOyOzpSraJlMHfOXWfJzlB6JVhJskTIrZwJUqoPdCzRIsB5leg6hQKcc+bHuzc F8sa+TzqgYfUMVsP4c2E83g6UkB396XSTWR5M= Message-ID: <4CEBC751.6090906@gmail.com> Date: Tue, 23 Nov 2010 14:53:21 +0100 From: Jiri Slaby User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; cs-CZ; rv:1.9.2.12) Gecko/20101026 SUSE/3.1.6 Thunderbird/3.1.6 MIME-Version: 1.0 To: Marek Belisko CC: Greg Kroah-Hartman , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/6] staging: ft1000: Use misc device instead self created device. References: <1290515373-16145-1-git-send-email-marek.belisko@open-nandra.com> <1290515373-16145-3-git-send-email-marek.belisko@open-nandra.com> In-Reply-To: <1290515373-16145-3-git-send-email-marek.belisko@open-nandra.com> X-Enigmail-Version: 1.1.2 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1380 Lines: 44 On 11/23/2010 01:29 PM, Marek Belisko wrote: > Use simple misc device for ioctl driver funtionality testing. > > Signed-off-by: Marek Belisko > --- > drivers/staging/ft1000/ft1000-usb/ft1000_chdev.c | 90 ++++++++++++++++++--- > 1 files changed, 77 insertions(+), 13 deletions(-) > > diff --git a/drivers/staging/ft1000/ft1000-usb/ft1000_chdev.c b/drivers/staging/ft1000/ft1000-usb/ft1000_chdev.c > index 1aec926..d1784a3 100644 > --- a/drivers/staging/ft1000/ft1000-usb/ft1000_chdev.c > +++ b/drivers/staging/ft1000/ft1000-usb/ft1000_chdev.c > @@ -32,6 +32,7 @@ > #include > #include > #include > +#include > > #include > #include > @@ -78,6 +79,47 @@ static struct file_operations ft1000fops = > .llseek = no_llseek, > }; > > +struct ft1000_misc_device { > + struct miscdevice dev; > + int inf_id; > +}; > + > +#define FREE_ID (0xFF) > + > +/* we support just 3 devices */ > +#define MAX_DEVICE 3 No, why this should be converted to miscdevice? Leave it as chrdev. regards, -- js -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/