Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756062Ab0KWR6t (ORCPT ); Tue, 23 Nov 2010 12:58:49 -0500 Received: from na3sys009aog109.obsmtp.com ([74.125.149.201]:60987 "HELO na3sys009aog109.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1754101Ab0KWR6r convert rfc822-to-8bit (ORCPT ); Tue, 23 Nov 2010 12:58:47 -0500 MIME-Version: 1.0 In-Reply-To: <8739qshwhm.fsf@deeprootsystems.com> References: <95f48a32a0256ecdb7148aa08d16f64928a7e5d8.1289935504.git.bengardiner@nanometrics.ca> <8739qshwhm.fsf@deeprootsystems.com> Date: Tue, 23 Nov 2010 12:58:46 -0500 Message-ID: Subject: Re: [PATCH v2 2/4] da850-evm: add UI Expander pushbuttons From: Ben Gardiner To: Kevin Hilman Cc: "Nori, Sekhar" , "davinci-linux-open-source@linux.davincidsp.com" , "linux-input@vger.kernel.org" , Dmitry Torokhov , "Govindarajan, Sriramakrishnan" , Paul Mundt , "linux-kernel@vger.kernel.org" , Alexander Clouter , Chris Cordahi Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1898 Lines: 56 Hi Kevin, Thank you for weighing in. On Tue, Nov 23, 2010 at 10:48 AM, Kevin Hilman wrote: > "Nori, Sekhar" writes: >>> [...] >>> -- which is less than Ideal. How about I replace the current changes >>> to arch/arm/mach-davinci/Kconfig with: >>> >>> config KEYBOARD_GPIO >>> ? ? ? ? default MACH_DAVINCI_DA850_EVM >>> ? ? ? ? select INPUT_POLLDEV >>> >>> So 1) gpio-keys functionality is default for the da850evm and 2) >>> whenever gpio-keys is enabled so is INPUT_POLLDEV. >> >> This looks better than what was posted earlier, but I am not >> sure if platforms should influence driver configuration this >> way. > > Agreed. ?In general, we should not have machine/platform specific > conditionals in generic Kconfigs. ? Generally, this should be handled in > machine/platform specific Kconfigs. My understanding is that Sekhar was expressing concern over putting generic config conditionals into machine/platform specific Kconfigs. It sounds like you are OK with generic config conditionals in machine/platform specific Kconfigs ala recent pca953x module build changes [1]. To be clear: I am proposing the following additions to arch/arm/mach-davinci/Kconfig: (slightly different than above). config KEYBOARD_GPIO ? ? ? ? default MACH_DAVINCI_DA850_EVM ? ? ? ? select INPUT_POLLDEV if MACH_DAVINCI_DA850_EVM I know it is always better to show the code: I will extract these contentious Kconfig changes into their own patch in the series when I post a new version. Best Regards, Ben Gardiner [1] http://article.gmane.org/gmane.linux.davinci/20918 --- Nanometrics Inc. http://www.nanometrics.ca -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/