Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752101Ab0KXIUf (ORCPT ); Wed, 24 Nov 2010 03:20:35 -0500 Received: from casper.infradead.org ([85.118.1.10]:39997 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751370Ab0KXIUe convert rfc822-to-8bit (ORCPT ); Wed, 24 Nov 2010 03:20:34 -0500 Subject: Re: [PATCH 1/3] jump label: add enabled/disabled state to jump label key entries From: Peter Zijlstra To: Jason Baron Cc: rostedt@goodmis.org, mingo@elte.hu, mathieu.desnoyers@polymtl.ca, hpa@zytor.com, tglx@linutronix.de, andi@firstfloor.org, roland@redhat.com, rth@redhat.com, masami.hiramatsu.pt@hitachi.com, fweisbec@gmail.com, avi@redhat.com, davem@davemloft.net, sam@ravnborg.org, ddaney@caviumnetworks.com, michael@ellerman.id.au, linux-kernel@vger.kernel.org In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT Date: Wed, 24 Nov 2010 09:20:09 +0100 Message-ID: <1290586809.2072.424.camel@laptop> Mime-Version: 1.0 X-Mailer: Evolution 2.30.3 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 559 Lines: 15 On Tue, 2010-11-23 at 16:27 -0500, Jason Baron wrote: > struct hlist_head modules; > unsigned long key; > + u32 nr_entries : 31, > + enabled : 1; > }; I still don't see why you do this, why not simply mandate that the key is of type atomic_t* and use *key as enabled state? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/