Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752101Ab0KXIYg (ORCPT ); Wed, 24 Nov 2010 03:24:36 -0500 Received: from eu1sys200aog119.obsmtp.com ([207.126.144.147]:45136 "EHLO eu1sys200aog119.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751175Ab0KXIYf (ORCPT ); Wed, 24 Nov 2010 03:24:35 -0500 Message-ID: <4CECCBAE.6080707@stericsson.com> Date: Wed, 24 Nov 2010 09:24:14 +0100 From: Bengt Jonsson User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.11) Gecko/20100713 Lightning/1.0b1 Thunderbird/3.0.6 MIME-Version: 1.0 To: Mark Brown Cc: Liam Girdwood , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Linus WALLEIJ Subject: Re: [PATCH 1/3] mfd: Added new regulator_data pointer to ab8500 board configuration References: <1290536754-21775-1-git-send-email-bengt.g.jonsson@stericsson.com> <1290536754-21775-2-git-send-email-bengt.g.jonsson@stericsson.com> <20101123183037.GA19212@rakim.wolfsonmicro.main> In-Reply-To: <20101123183037.GA19212@rakim.wolfsonmicro.main> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1265 Lines: 35 On 2010-11-23 19:30, Mark Brown wrote: > On Tue, Nov 23, 2010 at 07:25:52PM +0100, Bengt Jonsson wrote: > >> The ab8500 regulator board configuration will be better separated >> from the MFD board configuration. This patch adds a void pointer >> for this purpose. > > Adding something completely typesafe seems like a real loss - if you > want to point to something else at least point to a particular type - > eg, > > struct foo; > > struct pdata { > int other_stuff; > struct foo *foo; > }; > I get your point, I'll try this out. >> struct regulator_init_data *regulator[AB8500_NUM_REGULATORS]; >> + void *regulator_data; > > It'd also help if you could articulate the problem you see with the > current approach... The problem I see is that ab8500-core defines the number of regulators which I can see no reason for. If someone wants to add or remove a regulator they have to make a change in include/linux/mfd/ab8500.c as well as in the regulator files. I will add a better description in an updated patch. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/