Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752407Ab0KXJQm (ORCPT ); Wed, 24 Nov 2010 04:16:42 -0500 Received: from mail-qy0-f174.google.com ([209.85.216.174]:44573 "EHLO mail-qy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750969Ab0KXJQk convert rfc822-to-8bit (ORCPT ); Wed, 24 Nov 2010 04:16:40 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=qiA3dwhzGzKPmZRGWaqpW3yc4ck0RL3ZofX+dRcdy3aX8SBqQcSslmAmZ3HJ8U6J5a 7KOqLQ2rcIYhZocCMMcM62N+TnvYo5lvqWNL2RpD2CM8P0rtFZ5wIm3xwVcQt6t7XbvU Xhz1yrsNaBSimTwY4hB/mDkOOwLXB0eclXeA8= MIME-Version: 1.0 In-Reply-To: <4CEC3211.7050503@gmail.com> References: <1290515373-16145-1-git-send-email-marek.belisko@open-nandra.com> <1290515373-16145-3-git-send-email-marek.belisko@open-nandra.com> <4CEBC751.6090906@gmail.com> <4CEC3211.7050503@gmail.com> Date: Wed, 24 Nov 2010 10:16:36 +0100 Message-ID: Subject: Re: [PATCH 2/6] staging: ft1000: Use misc device instead self created device. From: Belisko Marek To: Jiri Slaby Cc: Greg Kroah-Hartman , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2748 Lines: 84 On Tue, Nov 23, 2010 at 10:28 PM, Jiri Slaby wrote: > On 11/23/2010 03:00 PM, Belisko Marek wrote: >> On Tue, Nov 23, 2010 at 2:53 PM, Jiri Slaby wrote: >>> On 11/23/2010 01:29 PM, Marek Belisko wrote: >>>> Use simple misc device for ioctl driver funtionality testing. >>>> >>>> Signed-off-by: Marek Belisko >>>> --- >>>>  drivers/staging/ft1000/ft1000-usb/ft1000_chdev.c |   90 ++++++++++++++++++--- >>>>  1 files changed, 77 insertions(+), 13 deletions(-) >>>> >>>> diff --git a/drivers/staging/ft1000/ft1000-usb/ft1000_chdev.c b/drivers/staging/ft1000/ft1000-usb/ft1000_chdev.c >>>> index 1aec926..d1784a3 100644 >>>> --- a/drivers/staging/ft1000/ft1000-usb/ft1000_chdev.c >>>> +++ b/drivers/staging/ft1000/ft1000-usb/ft1000_chdev.c >>>> @@ -32,6 +32,7 @@ >>>>  #include >>>>  #include >>>>  #include >>>> +#include >>>> >>>>  #include >>>>  #include >>>> @@ -78,6 +79,47 @@ static struct file_operations ft1000fops = >>>>       .llseek         = no_llseek, >>>>  }; >>>> >>>> +struct ft1000_misc_device { >>>> +     struct miscdevice dev; >>>> +     int inf_id; >>>> +}; >>>> + >>>> +#define FREE_ID (0xFF) >>>> + >>>> +/* we support just 3 devices */ >>>> +#define MAX_DEVICE 3 >>> >>> No, why this should be converted to miscdevice? Leave it as chrdev. >> Is there any problem with using miscdev? > > Yes, if you want more than a single device per system. > >> Old interface create /dev nodes with >> calling kernel thread and some usermode_helper or whatever. > > Yes, that's crap indeed. But doesn't judge for miscdevice. > >> Just convert to misc dev >> where this is done automatically. > > So the only thing you need to do is to send a uevent to udev appropriately. Could be used something like: register_chrdev(0,"ft1000", &fops) class = class_create(THIS_MODULE, "ft1000"); device_create(class, NULL, MKDEV(major, i), NULL, "ft1000%d", i); Then will be created different devices for every plugged device. This should have effect of automatic device node creation also suppose. > > regards, > -- > js > thanks, marek , -- as simple and primitive as possible ------------------------------------------------- Marek Belisko - OPEN-NANDRA Freelance Developer Ruska Nova Ves 219 | Presov, 08005 Slovak Republic Tel: +421 915 052 184 skype: marekwhite icq: 290551086 web: http://open-nandra.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/