Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753461Ab0KXKsz (ORCPT ); Wed, 24 Nov 2010 05:48:55 -0500 Received: from opensource.wolfsonmicro.com ([80.75.67.52]:39254 "EHLO opensource2.wolfsonmicro.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753378Ab0KXKsx (ORCPT ); Wed, 24 Nov 2010 05:48:53 -0500 Date: Wed, 24 Nov 2010 10:48:51 +0000 From: Mark Brown To: Bengt Jonsson Cc: Liam Girdwood , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Linus WALLEIJ Subject: Re: [PATCH 2/3] regulators: Update of ab8500 driver Message-ID: <20101124104851.GA24970@rakim.wolfsonmicro.main> References: <1290536754-21775-1-git-send-email-bengt.g.jonsson@stericsson.com> <1290536754-21775-3-git-send-email-bengt.g.jonsson@stericsson.com> <20101123183833.GB19212@rakim.wolfsonmicro.main> <4CECC555.8060408@stericsson.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4CECC555.8060408@stericsson.com> X-Cookie: Made with real ingredients. User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 597 Lines: 13 On Wed, Nov 24, 2010 at 08:57:09AM +0100, Bengt Jonsson wrote: > Removing the macros is just my suggestion. The disadvantage I see > with macros is that I need to read both the macro and the listing to > see what it really does. On the other hand, macros are probably more A line of comment at the top of the macro table would probably address that? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/