DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=date:from:to:cc:subject:message-id:mime-version:content-type
         :content-disposition:in-reply-to:user-agent;
        b=ImTvQ9D+KWWzX/g73jUdToIxVKhgj1wVjK6Q0BUC46NHnPvlFeLq/Cgihh9FQjE7As
         E8tqIGd9K1MMHe1j6ZGooFrorR/CbNwdmksZJQMbZyaiX2WbLGDq6KFV2W4uVc+nvvQk
         sGfPnEQ1gZmGPJR8cc/4sGOFe6kn6tYaPX3CM=
Date: Wed, 24 Nov 2010 12:49:01 +0000
From: Jarek Poplawski <jarkao2@gmail.com>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: LNML <netdev@vger.kernel.org>, Paul Mackerras <paulus@samba.org>,
        David Miller <davem@davemloft.net>, linux-ppp@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-2.6] net, ppp: Report correct error code if unit
	allocation failed
Message-ID: <20101124124901.GA9268@ff.dom.local>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20101123214344.GB1839@lenovo>
User-Agent: Mutt/1.5.18 (2008-05-17)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1013
Lines: 30

On 2010-11-23 22:43, Cyrill Gorcunov wrote:
> Allocating unit from ird might return several error codes
> not only -EAGAIN, so it should not be changed and returned
> precisely. Same time unit release procedure should be invoked
> only if device is unregistering.

IMHO this unit release fix should be in a separate patch.

...
> @@ -2668,10 +2668,10 @@ static void ppp_shutdown_interface(struc
>  		ppp->closing = 1;
>  		ppp_unlock(ppp);
>  		unregister_netdev(ppp->dev);
> +		unit_put(&pn->units_idr, ppp->file.index);
>  	} else
>  		ppp_unlock(ppp);
>  
> -	unit_put(&pn->units_idr, ppp->file.index);
>  	ppp->file.dead = 1;
>  	ppp->owner = NULL;
>  	wake_up_interruptible(&ppp->file.rwait);

Btw, it seems these last 3 lines could be moved similarly.

Jarek P.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/