Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754828Ab0KXQXb (ORCPT ); Wed, 24 Nov 2010 11:23:31 -0500 Received: from gate.lvk.cs.msu.su ([158.250.17.1]:44301 "EHLO mail.lvk.cs.msu.su" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753297Ab0KXQX2 (ORCPT ); Wed, 24 Nov 2010 11:23:28 -0500 X-Spam-ASN: From: Alexander Gordeev To: linux-kernel@vger.kernel.org Cc: "Nikita V\. Youshchenko" , linuxpps@ml.enneenne.com, Rodolfo Giometti , Alexander Gordeev , Tejun Heo Subject: [PATCHv5 10/17] pps: use BUG_ON for kernel API safety checks Date: Wed, 24 Nov 2010 19:15:48 +0300 Message-Id: X-Mailer: git-send-email 1.7.2.3 In-Reply-To: References: X-AV-Checked: ClamAV using ClamSMTP Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1200 Lines: 35 This way less overhead is involved when running production kernel. If you want to debug a pps client module please define DEBUG to enable the checks. Acked-by: Rodolfo Giometti Signed-off-by: Alexander Gordeev --- drivers/pps/kapi.c | 6 ++---- 1 files changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/pps/kapi.c b/drivers/pps/kapi.c index c42d3cb..3e8eb3f 100644 --- a/drivers/pps/kapi.c +++ b/drivers/pps/kapi.c @@ -166,10 +166,8 @@ void pps_event(struct pps_device *pps, struct pps_event_time *ts, int event, int captured = 0; struct pps_ktime ts_real; - if ((event & (PPS_CAPTUREASSERT | PPS_CAPTURECLEAR)) == 0) { - dev_err(pps->dev, "unknown event (%x)\n", event); - return; - } + /* check event type */ + BUG_ON((event & (PPS_CAPTUREASSERT | PPS_CAPTURECLEAR)) == 0); dev_dbg(pps->dev, "PPS event at %ld.%09ld\n", ts->ts_real.tv_sec, ts->ts_real.tv_nsec); -- 1.7.2.3 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/