Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755462Ab0KXQZm (ORCPT ); Wed, 24 Nov 2010 11:25:42 -0500 Received: from mail-ey0-f174.google.com ([209.85.215.174]:56385 "EHLO mail-ey0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755106Ab0KXQZX (ORCPT ); Wed, 24 Nov 2010 11:25:23 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; b=g+s9iDF9IcoC/Q/Lk2zbpNKmtZZ45/wcaGiw+skKheT0bR0V5qbicckP2I4cpb9k80 0eiimX6AJnUnLQRgbykAqmSE9EPeMERn6az5MxrrBLL5FUwzirRoCOFkT7sDmPqc8zEF GEovD4b4pAL3Jiv+T5JvTb98vtpXQUtBocciQ= Date: Wed, 24 Nov 2010 19:25:18 +0300 From: Cyrill Gorcunov To: Jarek Poplawski Cc: LNML , Paul Mackerras , David Miller , linux-ppp@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-2.6] net, ppp: Report correct error code if unit allocation failed Message-ID: <20101124162518.GA6450@lenovo> References: <20101123214344.GB1839@lenovo> <20101124124901.GA9268@ff.dom.local> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20101124124901.GA9268@ff.dom.local> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1505 Lines: 46 On Wed, Nov 24, 2010 at 12:49:01PM +0000, Jarek Poplawski wrote: > On 2010-11-23 22:43, Cyrill Gorcunov wrote: > > Allocating unit from ird might return several error codes > > not only -EAGAIN, so it should not be changed and returned > > precisely. Same time unit release procedure should be invoked > > only if device is unregistering. > > IMHO this unit release fix should be in a separate patch. > I thought about it, but still think it should be addressed at same patch. Though if a separate would be preferred still -- I've no problem in making two patches instead. > ... > > @@ -2668,10 +2668,10 @@ static void ppp_shutdown_interface(struc > > ppp->closing = 1; > > ppp_unlock(ppp); > > unregister_netdev(ppp->dev); > > + unit_put(&pn->units_idr, ppp->file.index); > > } else > > ppp_unlock(ppp); > > > > - unit_put(&pn->units_idr, ppp->file.index); > > ppp->file.dead = 1; > > ppp->owner = NULL; > > wake_up_interruptible(&ppp->file.rwait); > > Btw, it seems these last 3 lines could be moved similarly. yup, at least ppp->file.dead and ppp->owner for sure, I wanted make this patch 'unit' orientedc and do not touch anything aside, it should be a separate change. > > Jarek P. > Thanks for comments Jarek! Cyrill -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/