Date: Wed, 24 Nov 2010 09:07:30 -0800 (PST)
Message-Id: <20101124.090730.71102037.davem@davemloft.net>
To: mkl@pengutronix.de
Cc: tomoya-linux@dsn.okisemi.com, wg@grandegger.com, w.sang@pengutronix.de,
        chripell@fsfe.org, 21cnbao@gmail.com, sameo@linux.intel.com,
        socketcan-core@lists.berlios.de, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, andrew.chih.howe.khor@intel.com,
        qi.wang@intel.com, margie.foster@intel.com, yong.y.wang@intel.com,
        kok.howg.ewe@intel.com, joel.clark@intel.com
Subject: Re: [PATCH net-next-2.6 8/17 v3] can: EG20T PCH: Change Copyright
 and module description
From: David Miller <davem@davemloft.net>
In-Reply-To: <4CED14B0.9060208@pengutronix.de>
References: <4CED02C5.4080504@dsn.okisemi.com>
	<4CED14B0.9060208@pengutronix.de>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1485
Lines: 37

From: Marc Kleine-Budde <mkl@pengutronix.de>
Date: Wed, 24 Nov 2010 14:35:44 +0100

> On 11/24/2010 01:19 PM, Tomoya MORINAGA wrote:
>> Currently, Copyright and module description are not formal.
> 
> As David pointed out in an older version of this series, this patch does
> more than the subject indicates. Please fix.

Many patches still have this problem.

I'm getting really upset about this.

Look, it's simple.  Make sure your patch commit message describes
everything the patch is doing.

And in many of the cases where the commit message is not accurate, it
is actually the cases that the changes not documented are totally
unrelated and need to be split up into a different change.

I strongly suspect that the pch_can folks became extremely frustrated
doing these patch split-ups.  They find them pointless and they feel
that we're putting an unnecessary burdon upon them, and are having
trouble understanding why we require this and why it's so incredibly
important.

So they worked on this task with the most minimum of effort and care,
which is extremely unfortunate.

We will continue to push back until they get things correct, so all
they do by being lazy and careless is make more work for everyone,
including themselves.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/