Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755369Ab0KXTmV (ORCPT ); Wed, 24 Nov 2010 14:42:21 -0500 Received: from rcsinet10.oracle.com ([148.87.113.121]:29784 "EHLO rcsinet10.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751500Ab0KXTmU (ORCPT ); Wed, 24 Nov 2010 14:42:20 -0500 Date: Wed, 24 Nov 2010 11:41:09 -0800 From: Randy Dunlap To: akpm@linux-foundation.org, Pelagicore AB , linux-media@vger.kernel.org Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, Zimny Lech Subject: [PATCH -mmotm/-next] media: fix timblogiw kconfig & build error Message-Id: <20101124114109.c78df4e1.randy.dunlap@oracle.com> In-Reply-To: <201011240045.oAO0jYQ5016010@imap1.linux-foundation.org> References: <201011240045.oAO0jYQ5016010@imap1.linux-foundation.org> Organization: Oracle Linux Eng. X-Mailer: Sylpheed 2.7.1 (GTK+ 2.16.6; x86_64-unknown-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1333 Lines: 33 From: Randy Dunlap timblogiw uses dma() interfaces and it selects TIMB_DMA for that support. However, drivers/dma/ is not built unless CONFIG_DMA_ENGINE is enabled, so select/enable that symbol also. drivers/built-in.o: In function `timblogiw_close': timblogiw.c:(.text+0x4419fe): undefined reference to `dma_release_channel' drivers/built-in.o: In function `buffer_release': timblogiw.c:(.text+0x441a8d): undefined reference to `dma_sync_wait' drivers/built-in.o: In function `timblogiw_open': timblogiw.c:(.text+0x44212b): undefined reference to `__dma_request_channel' Signed-off-by: Randy Dunlap --- drivers/media/video/Kconfig | 1 + 1 file changed, 1 insertion(+) --- mmotm-2010-1123-1612.orig/drivers/media/video/Kconfig +++ mmotm-2010-1123-1612/drivers/media/video/Kconfig @@ -669,6 +669,7 @@ config VIDEO_HEXIUM_GEMINI config VIDEO_TIMBERDALE tristate "Support for timberdale Video In/LogiWIN" depends on VIDEO_V4L2 && I2C + select DMA_ENGINE select TIMB_DMA select VIDEO_ADV7180 select VIDEOBUF_DMA_CONTIG -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/