Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756042Ab0KXV7k (ORCPT ); Wed, 24 Nov 2010 16:59:40 -0500 Received: from na3sys009aog110.obsmtp.com ([74.125.149.203]:34151 "HELO na3sys009aog110.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1754641Ab0KXV7j (ORCPT ); Wed, 24 Nov 2010 16:59:39 -0500 From: Ben Gardiner To: Kevin Hilman , davinci-linux-open-source@linux.davincidsp.com, linux-input@vger.kernel.org, Dmitry Torokhov Cc: linux-kernel@vger.kernel.org, Chris Cordahi , Paul Mundt , Sekhar Nori , Gabor Juhos Subject: [PATCH v5 0/5] da850-evm: add gpio-{keys,leds} for UI and BB expanders Date: Wed, 24 Nov 2010 16:59:29 -0500 Message-Id: X-Mailer: git-send-email 1.7.0.4 In-Reply-To: References: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 5499 Lines: 119 Note: I must regrettably move on to other projects for awhile and will thus be unavailable to continue this integration effort. I am posting the most recent version of the series with a modified version of Gabor Juho's driver in the hopes that it will make the integration effort easier for whoever picks up the task when the time is right -- whether or not that is me. My apologies for the patchbomb. I will do my best to make time for reviews and testing of any future versions of the series. Best Regards, Ben Gardiner --- The da850-evm baseboard (BB) and its UI board both have tca6416 IO expanders. They are bootstrapped to different I2C addresses so they can be used concurrently. The expander on the UI board is currently used to enable/disable the peripherals that are available on the UI board. In addition to this functionality the expander is also connected to 8 pushbuttons. The expander on the baseboard is not currently used; it is connected to deep sleep enable, sw reset, a push button, some switches and LEDs. This proposed patch series enables the push buttons and switches on the UI and BB expanders using the gpio-keys polling mode patch by Gabor Juhos. Some work was performed to test irq-based gpio-keys support on the expanders (a WIP patch can be posted on request) but I believe that it is not possible to use irq-based gpio-keys on IO expanders for arm systems at this time. The attempt started when I noticed the patch of Alek Du and Alan Cox [1] which was recently committed [2]; a stab at integrating irq-based gpio-keys support based on that patch was attempted. I found that I either got a warning that the irq could not be mapped for the given gpio ; or, when N_IRQ was increased, a system freeze. >From what I have read (particularly the message by Grant Likely [3]) IRQs on IO expanders are not ready in ARM yet. I _think_ that the sparse IRQ rework by Thomas Gleixner [4] will resolve the blocker to irq-based gpio-keys support. In the meantime we have buttons and switches that we would like to excersise in our prototyping development. The patch to convert this series to irq-based gpio-keys will be straighforward once the support in arch/arm is there. There is an existing tca6416-keypad driver with polling support which I did not employ because it isn't possible to keep the gpio's used for peripheral enable/disable on the UI board or the LEDs on the baseboard registered while simultaneously registering the pushbuttons or switches as a tca6416-keypad instance. I tested this patch series using evtest on the resulting /dev/input/eventN devices and also on the event node of a non-polling gpio-keys instance to ensure that irq-based input handling is not broken by the introduction of the polling-mode gpio-keys patch. The non-polling instance creation and registration is not included in this series since it uses one of the boot-mode DIP switches and woult not (I think) be suitable for mainline. Disclaimer: I'm not an expert in irq's or gpio-keys; this is, in fact, my first proposed feature. Please feel free to correct me -- I welcome the chance to learn from your expertise. Ben Gardiner (4): da850-evm: add UI Expander pushbuttons da850-evm: extract defines for SEL{A,B,C} pins in UI expander da850-evm: add baseboard GPIO expander buttons, switches and LEDs da850-evm: KEYBOARD_GPIO_POLLED Kconfig conditional Gabor Juhos (1): [WIP] input: add input driver for polled GPIO buttons arch/arm/mach-davinci/Kconfig | 3 + arch/arm/mach-davinci/board-da850-evm.c | 306 +++++++++++++++++++++++++++-- drivers/input/keyboard/Kconfig | 16 ++ drivers/input/keyboard/Makefile | 2 + drivers/input/keyboard/gpio_keys_polled.c | 240 ++++++++++++++++++++++ include/linux/gpio_keys_polled.h | 26 +++ 6 files changed, 581 insertions(+), 12 deletions(-) create mode 100644 drivers/input/keyboard/gpio_keys_polled.c create mode 100644 include/linux/gpio_keys_polled.h --- Changes since v4: * integrated Gabor Juhos' polling gpio button driver in place of the gpio-keys patch of Paul Mundt and Alex Clouter * dont' line break error messages (Sekhar Nori) * whitespace cleanup (Sekhar Nori) Changes since v3: * introduced patch 5 in the series by extracting the Kconfig changes proposed in patch 2 of v3. * not gpio_request()'ing the sw_rst and deep_sleep_en lines as requested (Sekhar Nori) Changes since v2: * register a single input device for switches and keys on the baseboard since there is no benefit to separate devices with different polling intervals (Dmitry Torokhov) * use static array intialization and range intialization for platform data structure to minimize the amount of runtime intialization needed: (Sekhar Nori) * Use the da850_evm variable name prefix for static symbols in board-da850-evm.c Changes since v1: * use locally defined functions that are no-ops/error checkers when INPUT_POLLDEV is not defined. * disable polling mode support when input-polldev is a module and gpio_keys is builtin * set INPUT_POLLDEV default for DA850_EVM machine, but don't select it unconditionally * adding note to description about why tca6416-keypad was not used -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/