Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752120Ab0KYHOq (ORCPT ); Thu, 25 Nov 2010 02:14:46 -0500 Received: from mailout2.samsung.com ([203.254.224.25]:49249 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751728Ab0KYHOp (ORCPT ); Thu, 25 Nov 2010 02:14:45 -0500 Date: Thu, 25 Nov 2010 16:15:08 +0900 From: Kukjin Kim Subject: RE: [PATCH] ARM: s3x24xx: Fix gpiochip_add complaining. In-reply-to: <201011191253.58812.anarsoul@gmail.com> To: "'Vasily Khoruzhick'" , "'Lars-Peter Clausen'" Cc: linux-arm-kernel@lists.infradead.org, "'Ben Dooks'" , "'Marek Belisko'" , linux-kernel@vger.kernel.org Message-id: <00b201cb8c70$7ff96e30$7fec4a90$%kim@samsung.com> MIME-version: 1.0 X-Mailer: Microsoft Office Outlook 12.0 Content-type: text/plain; charset=us-ascii Content-language: ko Content-transfer-encoding: 7BIT Thread-index: AcuH2BcTf70IWHV8T0uO6eHfFhXIqwEk+Jpw References: <1290158139-16105-1-git-send-email-marek.belisko@open-nandra.com> <201011191123.22255.anarsoul@gmail.com> <4CE6547A.9070309@metafoo.de> <201011191253.58812.anarsoul@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1990 Lines: 57 Vasily Khoruzhick wrote: > > On Friday 19 November 2010 12:42:02 Lars-Peter Clausen wrote: > > Hi > > Hi all, > > Well it actually causes problems on systems with external gpio expanders, > > because now the additional banks will take up the space which was meant > > for the gpio expander chip and peripherals connected to it wont be > > accessible. > > Ok, but it would be nice to see some runtime soc-type detection for gpiolib. Yeah, I agree. We need to check SoC type for it during booting... > s3c2410/s3c2440/s3c2442 doesn't differ too much (actually, they're same in > gpiopart, s3c2410 lacks some gpiobanks that s3c244[0,2] have, and difference > in pull-up/pull-down on s3c2440 and s3c2442). > I think it's not good to make artificial restrictions for building single > binary kernel for these socs. > > > I sent a patch[1] about this some time ago, but I guess it was never > > applied... Maybe you missed my e-mail...or..I missed?...anyway... Could you please re-send it so that can get the patch via e-mail? > > Try pinging Ben or Kukjin :) > Thanks... Basically, I'd like to keep single binary for S3C24XX, maybe Ben also agree with this. But also there is some side effects, i.e., according to mach-s3c2410/Makefile.boot, zreladdr is different. But only selected 0x30108000 as zreladdr when build time because selected CONFIG_PM_H1940 with s3c2410_defconfig if there is no changes kernel configuration. This is just simple example. Maybe There are many similar examples. Hmm...anyway, we need to sort it out with keeping S3C24XX single binary. Will think some method for this... Best regards, Kgene. -- Kukjin Kim , Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/