Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752675Ab0KYLK7 (ORCPT ); Thu, 25 Nov 2010 06:10:59 -0500 Received: from sm-d311v.smileserver.ne.jp ([203.211.202.206]:13554 "EHLO sm-d311v.smileserver.ne.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751621Ab0KYLK5 (ORCPT ); Thu, 25 Nov 2010 06:10:57 -0500 Message-ID: <001c01cb8c91$6e93aef0$66f8800a@maildom.okisemi.com> From: "Tomoya MORINAGA" To: "Marc Kleine-Budde" Cc: "Wolfgang Grandegger" , "Wolfram Sang" , "Christian Pellegrin" , "Barry Song" <21cnbao@gmail.com>, "Samuel Ortiz" , , , , "David S. Miller" , , , , , , References: <4CED023E.1070009@dsn.okisemi.com> <4CED13B5.5020309@pengutronix.de> Subject: Re: [PATCH net-next-2.6 6/17 v3] can: EG20T PCH: Fix endianness issue Date: Thu, 25 Nov 2010 20:10:53 +0900 MIME-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit X-Priority: 3 X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook Express 6.00.2800.1983 X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2800.1983 X-Hosting-Pf: 0 X-NAI-Spam-Score: 1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1398 Lines: 33 On Wednesday, November 24, 2010 10:31 PM, Marc Kleine-Budde wrote : >> For easy to read, some sub-functions are created. >> >> >> Modify complex "goto" to do~while. >What about the next_flag in the rx_normal function? Can you get rid of >it, too? Subsequent Patch (11/17 Delete unnecessary ...) deletes "next_flag" in the rx_normal function. --- Thanks, Tomoya MORINAGA OKI SEMICONDUCTOR CO., LTD. ----- Original Message ----- From: "Marc Kleine-Budde" To: "Tomoya MORINAGA" Cc: "Wolfgang Grandegger" ; "Wolfram Sang" ; "Christian Pellegrin" ; "Barry Song" <21cnbao@gmail.com>; "Samuel Ortiz" ; ; ; ; "David S. Miller" ; ; ; ; ; ; Sent: Wednesday, November 24, 2010 10:31 PM Subject: Re: [PATCH net-next-2.6 6/17 v3] can: EG20T PCH: Fix endianness issue -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/