Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753073Ab0KYLuk (ORCPT ); Thu, 25 Nov 2010 06:50:40 -0500 Received: from ipmail04.adl6.internode.on.net ([150.101.137.141]:54452 "EHLO ipmail04.adl6.internode.on.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753037Ab0KYLui (ORCPT ); Thu, 25 Nov 2010 06:50:38 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AvsEAPvb7Ux5LcZJ/2dsb2JhbACjCnK+KIVHBA Date: Thu, 25 Nov 2010 22:50:33 +1100 From: Nick Piggin To: Boaz Harrosh Cc: Nick Piggin , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-ext4@vger.kernel.org, Roman Zippel , "Tigran A. Aivazian" , OGAWA Hirofumi , Dave Kleikamp , Bob Copeland , reiserfs-devel@vger.kernel.org, Christoph Hellwig , Evgeniy Dushistov , Jan Kara Subject: Re: [PATCH] exofs: simple fsync race fix Message-ID: <20101125115033.GA3643@amd> References: <20101125074909.GA4160@amd> <4CEE2C2E.4010003@panasas.com> <20101125100603.GA3164@amd> <4CEE3F9F.9070108@panasas.com> <4CEE3FD8.6080202@panasas.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4CEE3FD8.6080202@panasas.com> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 847 Lines: 21 This is fine, we'll get it merged before 2.6.37, just give a couple of days for review, I haven't had much confirmation from other vfs people about these problems. Thanks, Nick On Thu, Nov 25, 2010 at 12:52:08PM +0200, Boaz Harrosh wrote: > From: Nick Piggin > > It is incorrect to test inode dirty bits without participating in the inode > writeback protocol. Inode writeback sets I_SYNC and clears I_DIRTY_?, then > writes out the particular bits, then clears I_SYNC when it is done. BTW. it > may not completely write all pages out, so I_DIRTY_PAGES would get set > again. > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/