Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754560Ab0KYRVY (ORCPT ); Thu, 25 Nov 2010 12:21:24 -0500 Received: from mtagate1.uk.ibm.com ([194.196.100.161]:35483 "EHLO mtagate1.uk.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754493Ab0KYRVV (ORCPT ); Thu, 25 Nov 2010 12:21:21 -0500 Subject: Re: [patch 4/4] taskstats: Export "cdata_acct" with taskstats From: Michael Holzheu Reply-To: holzheu@linux.vnet.ibm.com To: Oleg Nesterov Cc: Shailabh Nagar , Andrew Morton , Peter Zijlstra , John stultz , Thomas Gleixner , Balbir Singh , Martin Schwidefsky , Heiko Carstens , Roland McGrath , linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org In-Reply-To: <20101125132639.GB25836@redhat.com> References: <20101119201108.269346583@linux.vnet.ibm.com> <20101119201144.871656307@linux.vnet.ibm.com> <20101125132639.GB25836@redhat.com> Content-Type: text/plain; charset="us-ascii" Organization: IBM Date: Thu, 25 Nov 2010 18:21:15 +0100 Message-ID: <1290705675.1941.73.camel@holzheu-laptop> Mime-Version: 1.0 X-Mailer: Evolution 2.28.3 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 941 Lines: 35 Hello Oleg, On Thu, 2010-11-25 at 14:26 +0100, Oleg Nesterov wrote: > On 11/19, Michael Holzheu wrote: > > > > From: Michael Holzheu > > > > With this patch the (full) cumulative CPU time is added to "struct taskstats". > > The CPU time is only returned for the thread group leader. > > > > ... > > > > + if (tsk->tgid == tsk->pid > > thread_group_leader() ? Yes, that's better. > > && lock_task_sighand(tsk, &flags)) { > > Do you really need ->siglock? Starting from 2.6.35 it is always > safe to access ->signal. Hmmm, if you say that... I just did it like it is done in e.g. fs/proc/base.c (proc_pid_limits). Can we remove the locking there, too? Michael -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/