Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752592Ab0KYU3v (ORCPT ); Thu, 25 Nov 2010 15:29:51 -0500 Received: from ogre.sisk.pl ([217.79.144.158]:56111 "EHLO ogre.sisk.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751801Ab0KYU3u convert rfc822-to-8bit (ORCPT ); Thu, 25 Nov 2010 15:29:50 -0500 From: "Rafael J. Wysocki" To: sedat.dilek@gmail.com Subject: Re: [PATCH 0/13] ACPI / PM: Rework power resources management Date: Thu, 25 Nov 2010 21:29:01 +0100 User-Agent: KMail/1.13.5 (Linux/2.6.37-rc3+; KDE/4.4.4; x86_64; ; ) Cc: LKML , Matthew Garrett , Len Brown References: <201011252115.02073.rjw@sisk.pl> In-Reply-To: <201011252115.02073.rjw@sisk.pl> MIME-Version: 1.0 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: 8BIT Message-Id: <201011252129.02027.rjw@sisk.pl> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2549 Lines: 75 On Thursday, November 25, 2010, Rafael J. Wysocki wrote: > On Thursday, November 25, 2010, Sedat Dilek wrote: > > On Thu, Nov 25, 2010 at 10:41 AM, Sedat Dilek > > wrote: > > > On Thu, Nov 25, 2010 at 10:11 AM, Sedat Dilek > > > wrote: > > >> Hi Rafael, > > >> > > [ ... ] > > >> # grep "error:" build_linux-next_next20101124.dileks.2.log > > >> /home/sd/src/linux-2.6/linux-2.6.37-rc3/debian/build/source_i386_none/drivers/platform/x86/fujitsu-laptop.c:692: > > >> error: implicit declaration of function ‘acpi_bus_get_power’ > > [ ... ] > > > > > > Guess this is conflicting with your patch > > > "12-13-ACPI-PM-Drop-acpi_bus_get_power.patch". > > > > > > - Sedat - > > > > > > P.S.: Note to myself, add the following snippet for testing purposes: > > > > > > [ debian/config/i386/none/config.686 ] > > > ... > > > ## > > > ## file: drivers/platform/x86/Kconfig > > > ## > > > # CONFIG_FUJITSU_LAPTOP is not set > > > - EOT - > > > > > > > Applied on top of linux-next (next-20101125) and running. > > > > Tested-by: Sedat Dilek > > Great, thanks a lot! > > I should have said the patchset is on top of the current Linus' tree. Actually it also breaks with the current Linus' tree, but the appended patch should fix it. Thanks, Rafael --- From: Rafael J. Wysocki Subject: Platform / x86: Make fujitsu_laptop use acpi_bus_update_power() Use the new function acpi_bus_update_power(), which is safer than acpi_bus_get_power(), for getting device power state in acpi_fujitsu_add(). Signed-off-by: Rafael J. Wysocki --- drivers/platform/x86/fujitsu-laptop.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: linux-2.6/drivers/platform/x86/fujitsu-laptop.c =================================================================== --- linux-2.6.orig/drivers/platform/x86/fujitsu-laptop.c +++ linux-2.6/drivers/platform/x86/fujitsu-laptop.c @@ -689,7 +689,7 @@ static int acpi_fujitsu_add(struct acpi_ if (error) goto err_free_input_dev; - result = acpi_bus_get_power(fujitsu->acpi_handle, &state); + result = acpi_bus_update_power(fujitsu->acpi_handle, &state); if (result) { printk(KERN_ERR "Error reading power state\n"); goto err_unregister_input_dev; -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/