Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752315Ab0KYUhs (ORCPT ); Thu, 25 Nov 2010 15:37:48 -0500 Received: from mail-qy0-f174.google.com ([209.85.216.174]:55420 "EHLO mail-qy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751657Ab0KYUhr convert rfc822-to-8bit (ORCPT ); Thu, 25 Nov 2010 15:37:47 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=googlemail.com; s=gamma; h=mime-version:reply-to:in-reply-to:references:date:message-id :subject:from:to:cc:content-type:content-transfer-encoding; b=HVEHhEw9Vb3K8zr3FZa1gge8jjLCkHvHo3TeWS4UCAs/ztJRlm0afNj8j4Tz+0JsD1 cnZt93OeAtPYgep4OMH2btVwOAsv5yGrVzQsT0gIKlIhmoHnUlRso7V6yXXYKMsp5VeU 51z/uFO/0dfgJKFVcGyZFR5Rsehocm6gZcuCk= MIME-Version: 1.0 Reply-To: sedat.dilek@gmail.com In-Reply-To: <201011252129.02027.rjw@sisk.pl> References: <201011252115.02073.rjw@sisk.pl> <201011252129.02027.rjw@sisk.pl> Date: Thu, 25 Nov 2010 21:37:46 +0100 Message-ID: Subject: Re: [PATCH 0/13] ACPI / PM: Rework power resources management From: Sedat Dilek To: "Rafael J. Wysocki" Cc: LKML , Matthew Garrett , Len Brown Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3248 Lines: 90 On Thu, Nov 25, 2010 at 9:29 PM, Rafael J. Wysocki wrote: > On Thursday, November 25, 2010, Rafael J. Wysocki wrote: >> On Thursday, November 25, 2010, Sedat Dilek wrote: >> > On Thu, Nov 25, 2010 at 10:41 AM, Sedat Dilek >> > wrote: >> > > On Thu, Nov 25, 2010 at 10:11 AM, Sedat Dilek >> > > wrote: >> > >> Hi Rafael, >> > >> >> > [ ... ] >> > >> # grep "error:" build_linux-next_next20101124.dileks.2.log >> > >> /home/sd/src/linux-2.6/linux-2.6.37-rc3/debian/build/source_i386_none/drivers/platform/x86/fujitsu-laptop.c:692: >> > >> error: implicit declaration of function ‘acpi_bus_get_power’ >> > [ ... ] >> > > >> > > Guess this is conflicting with your patch >> > > "12-13-ACPI-PM-Drop-acpi_bus_get_power.patch". >> > > >> > > - Sedat - >> > > >> > > P.S.: Note to myself, add the following snippet for testing purposes: >> > > >> > > [ debian/config/i386/none/config.686 ] >> > > ... >> > > ## >> > > ## file: drivers/platform/x86/Kconfig >> > > ## >> > > # CONFIG_FUJITSU_LAPTOP is not set >> > > - EOT - >> > > >> > >> > Applied on top of linux-next (next-20101125) and running. >> > >> >      Tested-by: Sedat Dilek >> >> Great, thanks a lot! >> >> I should have said the patchset is on top of the current Linus' tree. > > Actually it also breaks with the current Linus' tree, but the appended patch > should fix it. > > Thanks, > Rafael > > --- > From: Rafael J. Wysocki > Subject: Platform / x86: Make fujitsu_laptop use acpi_bus_update_power() > > Use the new function acpi_bus_update_power(), which is safer than > acpi_bus_get_power(), for getting device power state in > acpi_fujitsu_add(). > > Signed-off-by: Rafael J. Wysocki > --- >  drivers/platform/x86/fujitsu-laptop.c |    2 +- >  1 file changed, 1 insertion(+), 1 deletion(-) > > Index: linux-2.6/drivers/platform/x86/fujitsu-laptop.c > =================================================================== > --- linux-2.6.orig/drivers/platform/x86/fujitsu-laptop.c > +++ linux-2.6/drivers/platform/x86/fujitsu-laptop.c > @@ -689,7 +689,7 @@ static int acpi_fujitsu_add(struct acpi_ >        if (error) >                goto err_free_input_dev; > > -       result = acpi_bus_get_power(fujitsu->acpi_handle, &state); > +       result = acpi_bus_update_power(fujitsu->acpi_handle, &state); >        if (result) { >                printk(KERN_ERR "Error reading power state\n"); >                goto err_unregister_input_dev; > Sorry, I crapped my own quotes. Missed to catch line #860? - Sedat - $ cd ~/src/linux-2.6/linux-2.6.37-rc3/debian/build/source_i386_none $ grep --line-number -r acpi_bus_get_power -r drivers/platform/x86/ drivers/platform/x86/fujitsu-laptop.c:692: result = acpi_bus_get_power(fujitsu->acpi_handle, &state); drivers/platform/x86/fujitsu-laptop.c:860: result = acpi_bus_get_power(fujitsu_hotkey->acpi_handle, &state); -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/