Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753248Ab0KZCkq (ORCPT ); Thu, 25 Nov 2010 21:40:46 -0500 Received: from mga11.intel.com ([192.55.52.93]:8913 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752966Ab0KZCkp (ORCPT ); Thu, 25 Nov 2010 21:40:45 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.59,258,1288594800"; d="scan'208";a="630403683" Subject: Re: Free memory never fully used, swapping From: Shaohua Li To: KOSAKI Motohiro Cc: Mel Gorman , Simon Kirby , "linux-mm@kvack.org" , linux-kernel , Dave Hansen In-Reply-To: <20101126110244.B6DC.A69D9226@jp.fujitsu.com> References: <20101125161524.GE26037@csn.ul.ie> <1290736844.12777.10.camel@sli10-conroe> <20101126110244.B6DC.A69D9226@jp.fujitsu.com> Content-Type: text/plain; charset="UTF-8" Date: Fri, 26 Nov 2010 10:40:43 +0800 Message-ID: <1290739243.12777.17.camel@sli10-conroe> Mime-Version: 1.0 X-Mailer: Evolution 2.30.3 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2254 Lines: 63 On Fri, 2010-11-26 at 10:31 +0800, KOSAKI Motohiro wrote: > > record the order seems not sufficient. in balance_pgdat(), the for look > > exit only when: > > priority <0 or sc.nr_reclaimed >= SWAP_CLUSTER_MAX. > > but we do if (sc.nr_reclaimed < SWAP_CLUSTER_MAX) > > order = sc.order = 0; > > this means before we set order to 0, we already reclaimed a lot of > > pages, so I thought we need set order to 0 earlier before there are > > enough free pages. below is a debug patch. > > > > > > diff --git a/mm/vmscan.c b/mm/vmscan.c > > index d31d7ce..ee5d2ed 100644 > > --- a/mm/vmscan.c > > +++ b/mm/vmscan.c > > @@ -2117,6 +2117,26 @@ unsigned long try_to_free_mem_cgroup_pages(struct mem_cgroup *mem_cont, > > } > > #endif > > > > +static int all_zone_enough_free_pages(pg_data_t *pgdat) > > +{ > > + int i; > > + > > + for (i = 0; i < pgdat->nr_zones; i++) { > > + struct zone *zone = pgdat->node_zones + i; > > + > > + if (!populated_zone(zone)) > > + continue; > > + > > + if (zone->all_unreclaimable) > > + continue; > > + > > + if (!zone_watermark_ok(zone, 0, high_wmark_pages(zone) * 8, > > + 0, 0)) > > + return 0; > > + } > > + return 1; > > +} > > + > > /* is kswapd sleeping prematurely? */ > > static int sleeping_prematurely(pg_data_t *pgdat, int order, long remaining) > > { > > @@ -2355,7 +2375,8 @@ out: > > * back to sleep. High-order users can still perform direct > > * reclaim if they wish. > > */ > > - if (sc.nr_reclaimed < SWAP_CLUSTER_MAX) > > + if (sc.nr_reclaimed < SWAP_CLUSTER_MAX || > > + (order > 0 && all_zone_enough_free_pages(pgdat))) > > order = sc.order = 0; > > Ummm. this doesn't work. this place is processed every 32 pages reclaimed. > (see below code and comment). Theresore your patch break high order reclaim > logic. Yes, this will break high order reclaim, but we need a compromise. wrongly reclaim pages is more worse. could increase the watermark in all_zone_enough_free_pages() better? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/