Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753158Ab0KZD0h (ORCPT ); Thu, 25 Nov 2010 22:26:37 -0500 Received: from e3.ny.us.ibm.com ([32.97.182.143]:50691 "EHLO e3.ny.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752346Ab0KZD0g (ORCPT ); Thu, 25 Nov 2010 22:26:36 -0500 From: Jay Vosburgh To: David Strand cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] bonding: check for assigned mac before adopting the slaves mac address In-reply-to: References: <31169.1290641617@death> Comments: In-reply-to David Strand message dated "Wed, 24 Nov 2010 17:45:42 -0800." X-Mailer: MH-E 8.2; nmh 1.3; GNU Emacs 23.2.1 Date: Thu, 25 Nov 2010 19:26:31 -0800 Message-ID: <8879.1290741991@death> X-Content-Scanned: Fidelis XPS MAILER Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1012 Lines: 25 David Strand wrote: >We have a use case where we assign a mac to the bond device, because >the slave device configuration may change periodically. With older >kernels, it honored the assigned mac and everything was fine, with >2.6.36 it now uses the mac of whatever slave device is first instead >of our assigned one. > >ifenslave code and documentation appears to still support the old way, >where a bond assigned mac will reign supreme, so this patch restores >that behavior. Ok, fair enough. If we want to get back to the original behavior, however, your patch should only test for zero MAC address instead of testing for zero MAC address in addition to first slave. -J --- -Jay Vosburgh, IBM Linux Technology Center, fubar@us.ibm.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/