Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754788Ab0KZLBT (ORCPT ); Fri, 26 Nov 2010 06:01:19 -0500 Received: from mga11.intel.com ([192.55.52.93]:18038 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754635Ab0KZLBS (ORCPT ); Fri, 26 Nov 2010 06:01:18 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.59,260,1288594800"; d="scan'208";a="630496461" Date: Fri, 26 Nov 2010 12:01:12 +0100 From: Samuel Ortiz To: Joe Perches Cc: Jiri Kosina , linux-kernel@vger.kernel.org Subject: Re: [PATCH 06/14] drivers/mfd: Use printf extension %pR for struct resource Message-ID: <20101126110111.GG5520@sortiz-mobl> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1343 Lines: 46 Hi Joe, On Fri, Nov 12, 2010 at 01:37:56PM -0800, Joe Perches wrote: > Using %pR standardizes the struct resource output. > > Signed-off-by: Joe Perches Patch applied, thanks. Cheers, Samuel. > --- > drivers/mfd/sm501.c | 7 ++----- > 1 files changed, 2 insertions(+), 5 deletions(-) > > diff --git a/drivers/mfd/sm501.c b/drivers/mfd/sm501.c > index bc9275c..78638cf 100644 > --- a/drivers/mfd/sm501.c > +++ b/drivers/mfd/sm501.c > @@ -745,11 +745,8 @@ static int sm501_register_device(struct sm501_devdata *sm, > int ret; > > for (ptr = 0; ptr < pdev->num_resources; ptr++) { > - printk(KERN_DEBUG "%s[%d] flags %08lx: %08llx..%08llx\n", > - pdev->name, ptr, > - pdev->resource[ptr].flags, > - (unsigned long long)pdev->resource[ptr].start, > - (unsigned long long)pdev->resource[ptr].end); > + printk(KERN_DEBUG "%s[%d] %pR\n", > + pdev->name, ptr, &pdev->resource[ptr]); > } > > ret = platform_device_register(pdev); > -- > 1.7.3.1.g432b3.dirty > -- Intel Open Source Technology Centre http://oss.intel.com/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/