Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753954Ab0KZNRa (ORCPT ); Fri, 26 Nov 2010 08:17:30 -0500 Received: from vpn.id2.novell.com ([195.33.99.129]:39710 "EHLO vpn.id2.novell.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751043Ab0KZNR3 convert rfc822-to-8bit (ORCPT ); Fri, 26 Nov 2010 08:17:29 -0500 Message-Id: <4CEFC1AA0200007800024734@vpn.id2.novell.com> X-Mailer: Novell GroupWise Internet Agent 8.0.1 Date: Fri, 26 Nov 2010 13:18:18 +0000 From: "Jan Beulich" To: Cc: , Subject: your patch "x86, olpc: Rework BIOS signature check" Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 8BIT Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 703 Lines: 17 ... adds a select of OLPC_OPENFIRMWARE to the OLPC option, which contradicts OLPC_OPENFIRMWARE itself depending on !X86_64 && !X86_PAE. Are the latter dependencies not necessary anymore (the X86_64 one wasn't very meaningful anyway, since these options all sit inside a "if X86_32"), or should the select be conditional? Also, how meaningful is having OLPC_OPENFIRMWARE on but OLPC off (i.e. can OLPC_OPENFIRMWARE perhaps go away altogether)? Thanks, Jan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/