Date: Fri, 26 Nov 2010 08:27:58 -0500
From: Kyle McMartin <kyle@mcmartin.ca>
To: Jiri Slaby <jslaby@suse.cz>
Cc: Kyle McMartin <kyle@mcmartin.ca>, gregkh@suse.de,
        akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
        Alan Cox <alan@lxorguk.ukuu.org.uk>
Subject: Re: [PATCH 1/1] TTY: don't allow reopen when ldisc is changing
Message-ID: <20101126132758.GN22651@bombadil.infradead.org>
References: <4CEE93FF.3040507@suse.cz>
 <1290705383-6608-1-git-send-email-jslaby@suse.cz>
 <20101126002840.GL22651@bombadil.infradead.org>
 <4CEF65CA.9020403@suse.cz>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4CEF65CA.9020403@suse.cz>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 962
Lines: 25

On Fri, Nov 26, 2010 at 08:46:18AM +0100, Jiri Slaby wrote:
> On 11/26/2010 01:28 AM, Kyle McMartin wrote:
> > On Thu, Nov 25, 2010 at 06:16:23PM +0100, Jiri Slaby wrote:
> >> -	if (test_bit(TTY_CLOSING, &tty->flags))
> >> +	if (test_bit(TTY_CLOSING, &tty->flags) ||
> >> +			test_bit(TTY_LDISC_CHANGING, &tty->flags))
> >>  		return -EIO;
> >>  
> >>  	if (driver->type == TTY_DRIVER_TYPE_PTY &&
> > 
> > Unfortunately, users report this doesn't seem to fix things for them
> > (built against 2.6.36 (plus another patch you wrote iirc.))
> 
> Which patches exactly do you have? You need three of mine in 2.6.36.
> 

Just tty-restore-tty_ldisc_wait_idle.patch on top of 2.6.36.1, I'll grab
the other two now.

--Kyle
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/