DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :cc:content-type:content-transfer-encoding;
        b=tsbaLA64mmOXmNx0z55XR3zxXFVz8V7TErycL72+7ecpxwSuEFx3IfPoc+yf1HTz1s
         xoqO4r+4ztDk5Lg8DCowmtDjPcbMCfSGIWI7I1XJcgm6tpif7gp14rJUfzxjWescdfcA
         lxskCKcXykrZrQfcW92BWNaubYGp17vN+joL8=
MIME-Version: 1.0
In-Reply-To: <4CF30B46.4000203@pavlinux.ru>
References: <4CF30B46.4000203@pavlinux.ru>
Date: Mon, 29 Nov 2010 10:29:38 +0800
Message-ID: <AANLkTikjDfyWY=Gy7VkdvEGNnYB9kb_iCqNDP7H9W5z4@mail.gmail.com>
Subject: Re: [PATCH] Repalce strncmp by memcmp
From: Ming Lei <tom.leiming@gmail.com>
To: pavel@pavlinux.ru
Cc: LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 532
Lines: 19

Hi,

2010/11/29 Pavel Vasilyev <pavel@pavlinux.ru>:
>
> ? ?This patch replace all strncmp(a, b, c) by ?memcmp(a, b, c).
>
> I test on x86_64 (AMD Opteron 285).

In fact, memcmp doesn't handle case of tail of string, so
it is not safe to replace strncmp with memcmp

thanks,
-- 
Lei Ming
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/