Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752694Ab0K2J6V (ORCPT ); Mon, 29 Nov 2010 04:58:21 -0500 Received: from mail-iw0-f174.google.com ([209.85.214.174]:61866 "EHLO mail-iw0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751841Ab0K2J6T convert rfc822-to-8bit (ORCPT ); Mon, 29 Nov 2010 04:58:19 -0500 MIME-Version: 1.0 X-Originating-IP: [66.201.52.98] In-Reply-To: <1290821087.2529.252.camel@helium> References: <536589.12568.qm@web180310.mail.gq1.yahoo.com> <1290716548.2529.136.camel@helium> <1290821087.2529.252.camel@helium> From: Ohad Ben-Cohen Date: Mon, 29 Nov 2010 11:57:58 +0200 Message-ID: Subject: Re: [PATCH v2 1/4] drivers: hwspinlock: add generic framework To: David Brownell Cc: MugdhaKamoolkar , "linux-omap@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "akpm@linux-foundation.org" , Greg KH , Tony Lindgren , BenoitCousson , Grant Likely , HariKanigeri , SumanAnna , Kevin Hilman , Arnd Bergmann Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1009 Lines: 29 On Sat, Nov 27, 2010 at 3:24 AM, David Brownell wrote: > Your intent "generic" is fine, but you've not achieved it and thus I > think you shouldn't imply that you have. ? Dropping the word "generic" > should ?suffice; it _is_ a framework, and maybe the next person working > with hardware spinlocks can finish generalizing (and add use cases). Sure, I can drop the word "generic". > Haven't looked at RT in a long time. ?Just look at the current RT > patchset to see if it still has several spinlock variants. ?ISTR the > "raw" spinlock stuff came from there not long ago. ?Much compile-time > magic was involved in switching between variants. I'll take a look there and see if I catch anything relevant. Thanks, Ohad. > > - Dave > > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/