Date: Mon, 29 Nov 2010 16:15:21 +0100 (CET)
From: Jiri Kosina <jkosina@suse.cz>
To: Debora Velarde <debora@linux.vnet.ibm.com>,
        Rajiv Andrade <srajiv@linux.vnet.ibm.com>,
        Marcel Selhorst <m.selhorst@sirrix.com>
Cc: linux-kernel@vger.kernel.org, tpmdd-devel@lists.sourceforge.net,
        "Rafael J. Wysocki" <rjw@suse.com>
Subject: Re: [REGRESSION] Suspend fails because of TPM modules
In-Reply-To: <alpine.LNX.2.00.1011291554570.981@pobox.suse.cz>
Message-ID: <alpine.LNX.2.00.1011291614060.981@pobox.suse.cz>
References: <alpine.LNX.2.00.1011291554570.981@pobox.suse.cz>
User-Agent: Alpine 2.00 (LNX 1167 2008-08-23)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1395
Lines: 42

On Mon, 29 Nov 2010, Jiri Kosina wrote:

> Hi,
> 
> on my thinkpad x200s (and I have seen reports on different HW as well), 
> suspend fails when TPM modules are loaded.
> 
> 	tpm_tis 00:0a: tpm_transmit: tpm_send: error -5
> 	legacy_suspend(): pnp_bus_suspend+0x0/0xa0 returns -5
> 	PM: Device 00:0a failed to suspend: error -5
> 	PM: Some devices failed to suspend
> 
> Once tpm, tpm_bios, tpm_tis and tpm modules are unloaded, suspend/resume 
> works.
> 
> This is a regression. It definitely worked on this very same hardware on 
> 2.6.34. Any kernel between .34 and .37 wasn't booted there, so I don't 
> have any data of that kind.
> 
> I can try bisecting it, but if anyone sees immediately what the culprit 
> might be, that'd be helpful.

I just found out, that if I modprobe tpm_tis module with

	itpm=1

parameter, the problem doesn't happen any more and suspend works fine.

This definitely wasn't needed on older kernels though, so I'd consider 
that still a regression.

Also, can't we make the module automatically detect the machines on which 
to apply the workaround? Let's say, based on DMI?

-- 
Jiri Kosina
SUSE Labs, Novell Inc.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/