Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754372Ab0K2PUK (ORCPT ); Mon, 29 Nov 2010 10:20:10 -0500 Received: from cavan.codon.org.uk ([93.93.128.6]:56274 "EHLO cavan.codon.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752851Ab0K2PUI (ORCPT ); Mon, 29 Nov 2010 10:20:08 -0500 Date: Mon, 29 Nov 2010 15:19:53 +0000 From: Matthew Garrett To: Jiri Kosina Cc: Debora Velarde , Rajiv Andrade , Marcel Selhorst , linux-kernel@vger.kernel.org, tpmdd-devel@lists.sourceforge.net, "Rafael J. Wysocki" Subject: Re: [REGRESSION] Suspend fails because of TPM modules Message-ID: <20101129151953.GA9501@srcf.ucam.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.18 (2008-05-17) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: mjg59@cavan.codon.org.uk X-SA-Exim-Scanned: No (on cavan.codon.org.uk); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 771 Lines: 23 On Mon, Nov 29, 2010 at 04:15:21PM +0100, Jiri Kosina wrote: > I just found out, that if I modprobe tpm_tis module with > > itpm=1 > > parameter, the problem doesn't happen any more and suspend works fine. > > This definitely wasn't needed on older kernels though, so I'd consider > that still a regression. > > Also, can't we make the module automatically detect the machines on which > to apply the workaround? Let's say, based on DMI? http://lkml.org/lkml/2010/10/21/456 -- Matthew Garrett | mjg59@srcf.ucam.org -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/