Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753920Ab0K2PW4 (ORCPT ); Mon, 29 Nov 2010 10:22:56 -0500 Received: from e24smtp01.br.ibm.com ([32.104.18.85]:52422 "EHLO e24smtp01.br.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751621Ab0K2PWz (ORCPT ); Mon, 29 Nov 2010 10:22:55 -0500 Message-ID: <4CF3C547.6020302@linux.vnet.ibm.com> Date: Mon, 29 Nov 2010 13:22:47 -0200 From: Rajiv Andrade User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.12) Gecko/20101027 Lightning/1.0b2 Thunderbird/3.1.6 MIME-Version: 1.0 To: Jiri Kosina CC: Debora Velarde , Marcel Selhorst , linux-kernel@vger.kernel.org, tpmdd-devel@lists.sourceforge.net, "Rafael J. Wysocki" , jmorris@namei.org, mjg@redhat.com Subject: Re: [REGRESSION] Suspend fails because of TPM modules References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1709 Lines: 52 On 11/29/2010 01:15 PM, Jiri Kosina wrote: > On Mon, 29 Nov 2010, Jiri Kosina wrote: > >> Hi, >> >> on my thinkpad x200s (and I have seen reports on different HW as well), >> suspend fails when TPM modules are loaded. >> >> tpm_tis 00:0a: tpm_transmit: tpm_send: error -5 >> legacy_suspend(): pnp_bus_suspend+0x0/0xa0 returns -5 >> PM: Device 00:0a failed to suspend: error -5 >> PM: Some devices failed to suspend >> >> Once tpm, tpm_bios, tpm_tis and tpm modules are unloaded, suspend/resume >> works. >> >> This is a regression. It definitely worked on this very same hardware on >> 2.6.34. Any kernel between .34 and .37 wasn't booted there, so I don't >> have any data of that kind. >> >> I can try bisecting it, but if anyone sees immediately what the culprit >> might be, that'd be helpful. > I just found out, that if I modprobe tpm_tis module with > > itpm=1 > > parameter, the problem doesn't happen any more and suspend works fine. > > This definitely wasn't needed on older kernels though, so I'd consider > that still a regression. > > Also, can't we make the module automatically detect the machines on which > to apply the workaround? Let's say, based on DMI? > There's a patch already submitted that solves this: http://marc.info/?l=linux-kernel&m=128769741101534&w=2 This side effect (to solve the suspend issue) should increase its urgency I think. James, any thoughts? Rajiv -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/