Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753922Ab0K2RA2 (ORCPT ); Mon, 29 Nov 2010 12:00:28 -0500 Received: from lennier.cc.vt.edu ([198.82.162.213]:52234 "EHLO lennier.cc.vt.edu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751429Ab0K2RA0 (ORCPT ); Mon, 29 Nov 2010 12:00:26 -0500 X-Mailer: exmh version 2.7.2 01/07/2005 with nmh-1.2 To: mat Cc: linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org, linux-next@vger.kernel.org, Arjan van de Ven , James Morris , Andrew Morton , Andi Kleen , Thomas Gleixner , "H. Peter Anvin" , Ingo Molnar , Rusty Russell , Stephen Rothwell , Dave Jones , Siarhei Liakh , Kees Cook Subject: Re: [PATCH 3/3 V13] RO/NX protection for loadable kernel In-Reply-To: Your message of "Fri, 26 Nov 2010 18:23:55 +0100." <20101126182355.62615dff@mat-laptop> From: Valdis.Kletnieks@vt.edu References: <4CE2F914.9070106@free.fr> <24422.1290656467@localhost> <20101126182355.62615dff@mat-laptop> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="==_Exmh_1291049944_5346P"; micalg=pgp-sha1; protocol="application/pgp-signature" Content-Transfer-Encoding: 7bit Date: Mon, 29 Nov 2010 11:59:04 -0500 Message-ID: <8825.1291049944@localhost> X-Mirapoint-Received-SPF: 128.173.14.107 localhost Valdis.Kletnieks@vt.edu 2 pass X-Mirapoint-IP-Reputation: reputation=neutral-1, source=Fixed, refid=n/a, actions=MAILHURDLE SPF TAG X-Junkmail-Status: score=10/50, host=dagger.cc.vt.edu X-Junkmail-Signature-Raw: score=unknown, refid=str=0001.0A020201.4CF3DBDA.0018,ss=1,fgs=0, ip=0.0.0.0, so=2010-07-22 22:03:31, dmn=2009-09-10 00:05:08, mode=single engine X-Junkmail-IWF: false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1882 Lines: 60 --==_Exmh_1291049944_5346P Content-Type: text/plain; charset=us-ascii On Fri, 26 Nov 2010 18:23:55 +0100, mat said: > Le Wed, 24 Nov 2010 22:41:07 -0500, > Valdis.Kletnieks@vt.edu a =E9crit : > > This is incompatible with CONFIG_JUMP_LABEL: > > > > [ 252.093624] BUG: unable to handle kernel paging request at > > ffffffffa0680764 [ 252.094008] IP: [] > > generic_swap+0xa/0x1a [ 252.094008] PGD 1a1e067 PUD 1a22063 PMD > > 1093ac067 PTE 8000000109786161 [ 252.094008] Oops: 0003 [#1] PREEMPT > > SMP > > > +config DEBUG_SET_MODULE_RONX > > > + bool "Set loadable kernel module data as NX and text as RO" > > > + default n > > > + depends on X86 && MODULES > > > > depends on X86 && MODULES && !JUMP_LABEL > could you try the attached patch ? > > on module load, we sort the __jump_table section. So we should make it > writable. > diff --git a/arch/x86/include/asm/jump_label.h b/arch/x86/include/asm/jump_la bel.h > index f52d42e..574dbc2 100644 > --- a/arch/x86/include/asm/jump_label.h > +++ b/arch/x86/include/asm/jump_label.h > @@ -14,7 +14,7 @@ > do { \ > asm goto("1:" \ > JUMP_LABEL_INITIAL_NOP \ > - ".pushsection __jump_table, \"a\" \n\t"\ > + ".pushsection __jump_table, \"aw\" \n\t"\ Confirming that fixes the issue I was seeing, thanks... --==_Exmh_1291049944_5346P Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Exmh version 2.5 07/13/2001 iD8DBQFM89vYcC3lWbTT17ARAjZYAJwIelyIEE0f7SOzWmergTbL9PEncQCfYKXH 5ABgu3cvaJfj1igKBmps0IM= =LO7U -----END PGP SIGNATURE----- --==_Exmh_1291049944_5346P-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/