Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753242Ab0K2UIK (ORCPT ); Mon, 29 Nov 2010 15:08:10 -0500 Received: from mail-qy0-f181.google.com ([209.85.216.181]:52352 "EHLO mail-qy0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753173Ab0K2UIJ convert rfc822-to-8bit (ORCPT ); Mon, 29 Nov 2010 15:08:09 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=qSYpCrXOwhPReysQyz08GyuKNUxIUk3Kti4T7NI0IMyIsKQ6Hx7tJs7JBdTLFw3Oej r9j9L+Jlp7/zXcMZ39ZWRg9diqDe6ZNWe7qJ152voIoaUbdPqWGhg8g+FeN66SSgqS+g /cZfqMRczkmJ8X9DjwzblvGR0lSKmyY1Ty1ck= MIME-Version: 1.0 In-Reply-To: <20101129194414.GB14086@kroah.com> References: <1290515373-16145-1-git-send-email-marek.belisko@open-nandra.com> <1290515373-16145-3-git-send-email-marek.belisko@open-nandra.com> <4CEBC751.6090906@gmail.com> <4CEC3211.7050503@gmail.com> <20101129194414.GB14086@kroah.com> Date: Mon, 29 Nov 2010 21:08:07 +0100 Message-ID: Subject: Re: [PATCH 2/6] staging: ft1000: Use misc device instead self created device. From: Belisko Marek To: Greg KH Cc: Jiri Slaby , devel@driverdev.osuosl.org, Greg Kroah-Hartman , linux-kernel@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3612 Lines: 99 On Mon, Nov 29, 2010 at 8:44 PM, Greg KH wrote: > On Wed, Nov 24, 2010 at 10:16:36AM +0100, Belisko Marek wrote: >> On Tue, Nov 23, 2010 at 10:28 PM, Jiri Slaby wrote: >> > On 11/23/2010 03:00 PM, Belisko Marek wrote: >> >> On Tue, Nov 23, 2010 at 2:53 PM, Jiri Slaby wrote: >> >>> On 11/23/2010 01:29 PM, Marek Belisko wrote: >> >>>> Use simple misc device for ioctl driver funtionality testing. >> >>>> >> >>>> Signed-off-by: Marek Belisko >> >>>> --- >> >>>>  drivers/staging/ft1000/ft1000-usb/ft1000_chdev.c |   90 ++++++++++++++++++--- >> >>>>  1 files changed, 77 insertions(+), 13 deletions(-) >> >>>> >> >>>> diff --git a/drivers/staging/ft1000/ft1000-usb/ft1000_chdev.c b/drivers/staging/ft1000/ft1000-usb/ft1000_chdev.c >> >>>> index 1aec926..d1784a3 100644 >> >>>> --- a/drivers/staging/ft1000/ft1000-usb/ft1000_chdev.c >> >>>> +++ b/drivers/staging/ft1000/ft1000-usb/ft1000_chdev.c >> >>>> @@ -32,6 +32,7 @@ >> >>>>  #include >> >>>>  #include >> >>>>  #include >> >>>> +#include >> >>>> >> >>>>  #include >> >>>>  #include >> >>>> @@ -78,6 +79,47 @@ static struct file_operations ft1000fops = >> >>>>       .llseek         = no_llseek, >> >>>>  }; >> >>>> >> >>>> +struct ft1000_misc_device { >> >>>> +     struct miscdevice dev; >> >>>> +     int inf_id; >> >>>> +}; >> >>>> + >> >>>> +#define FREE_ID (0xFF) >> >>>> + >> >>>> +/* we support just 3 devices */ >> >>>> +#define MAX_DEVICE 3 >> >>> >> >>> No, why this should be converted to miscdevice? Leave it as chrdev. >> >> Is there any problem with using miscdev? >> > >> > Yes, if you want more than a single device per system. >> > >> >> Old interface create /dev nodes with >> >> calling kernel thread and some usermode_helper or whatever. >> > >> > Yes, that's crap indeed. But doesn't judge for miscdevice. >> > >> >> Just convert to misc dev >> >> where this is done automatically. >> > >> > So the only thing you need to do is to send a uevent to udev appropriately. >> Could be used something like: >> register_chrdev(0,"ft1000", &fops) >> class = class_create(THIS_MODULE, "ft1000"); >> device_create(class, NULL, MKDEV(major, i), NULL, "ft1000%d", i); >> Then will be created different devices for every plugged device. >> This should have effect of automatic device node creation also suppose. > > Please don't create new classes. > > Is this a USB device?  If so, why not just use the USB major number? Yes it is USB device. > Just ask me and I can reserve you a USB minor number for your driver. Idea behind existing code is that for every plugged device you will have created /dev node. NUmber of devices was limited by number of plugged devices. But who will plug more then one device which just used for internet connection? So maybe I should implement some limit and would be nice if you could reserve me some USB minors (lest say max. 3 devices?). > > thanks, > > greg k-h > thanks, marek -- as simple and primitive as possible ------------------------------------------------- Marek Belisko - OPEN-NANDRA Freelance Developer Ruska Nova Ves 219 | Presov, 08005 Slovak Republic Tel: +421 915 052 184 skype: marekwhite icq: 290551086 web: http://open-nandra.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/