Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753518Ab0K2WCT (ORCPT ); Mon, 29 Nov 2010 17:02:19 -0500 Received: from rcsinet10.oracle.com ([148.87.113.121]:18773 "EHLO rcsinet10.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752361Ab0K2WCS convert rfc822-to-8bit (ORCPT ); Mon, 29 Nov 2010 17:02:18 -0500 Date: Mon, 29 Nov 2010 14:01:31 -0800 From: Randy Dunlap To: Peter =?ISO-8859-1?Q?H=FCwe?= Cc: "Greg Kroah-Hartman" , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, Mark Allyn , Joe Perches , Ben Hutchings , Alan Cox Subject: Re: [PATCH 3/3] staging/sep: Fix sparse printk format warning Message-Id: <20101129140131.9dd954a9.randy.dunlap@oracle.com> In-Reply-To: <201011292259.12527.PeterHuewe@gmx.de> References: <1291066280-19126-1-git-send-email-peterhuewe@gmx.de> <1291066280-19126-3-git-send-email-peterhuewe@gmx.de> <20101129134943.4ef92448.randy.dunlap@oracle.com> <201011292259.12527.PeterHuewe@gmx.de> Organization: Oracle Linux Eng. X-Mailer: Sylpheed 2.7.1 (GTK+ 2.16.6; x86_64-unknown-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 904 Lines: 24 On Mon, 29 Nov 2010 22:59:11 +0100 Peter H?we wrote: > > Are you sure? I'm used to these being gcc warnings, not sparse. > You're right - these are generated by gcc ;) sorry for the confusion. > > > Also, this fixes the warnings on x86_64 but not on x86_32/i386: > You're right again, I'm on x86_64 - so what should I use instead? I dunno, I've tried to fix this myself and the only thing that I have been successful with is casting those ioctl values to (unsigned long) and using %lx to print them. > (atleast the patch fixes the size_t format strings ;) agreed. --- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code *** -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/