Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755669Ab0K2Xfe (ORCPT ); Mon, 29 Nov 2010 18:35:34 -0500 Received: from ozlabs.org ([203.10.76.45]:50635 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752953Ab0K2Xfc (ORCPT ); Mon, 29 Nov 2010 18:35:32 -0500 From: Rusty Russell To: Steven Rostedt Subject: Re: [PATCH 3/3 V13] RO/NX protection for loadable kernel Date: Tue, 30 Nov 2010 10:05:29 +1030 User-Agent: KMail/1.13.5 (Linux/2.6.35-22-generic-pae; KDE/4.5.1; i686; ; ) Cc: matthieu castet , linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org, linux-next@vger.kernel.org, Arjan van de Ven , James Morris , Andrew Morton , Andi Kleen , Thomas Gleixner , "H. Peter Anvin" , Ingo Molnar , Stephen Rothwell , Dave Jones , Siarhei Liakh , Kees Cook , Peter Zijlstra References: <4CE2F914.9070106@free.fr> <20101129181542.GA11630@home.goodmis.org> In-Reply-To: <20101129181542.GA11630@home.goodmis.org> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201011301005.29532.rusty@rustcorp.com.au> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 771 Lines: 20 On Tue, 30 Nov 2010 04:45:42 am Steven Rostedt wrote: > This patch breaks function tracer: ... > Here we set the text read only before we call the notifiers. The > function tracer changes the calls to mcount into nops via a notifier > call so this must be done after the module notifiers. That seems fine. I note that both before and after this patch we potentially execute code in the module (via parse_args) before we set it ro & nx. But fixing this last bit of coverage is probably not worth the pain... Cheers, Rusty. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/